Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Side by Side Diff: third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

Issue 2555923003: Make InvalidatableInterpolation's InterpolationTypes decided at effect application time (Closed)
Patch Set: Extended InterpolationTypesMap lifetime scope to fix release crash Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc.
6 * All rights reserved. 6 * All rights reserved.
7 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 7 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
8 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 8 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
9 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. 9 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
10 * (http://www.torchmobile.com/) 10 * (http://www.torchmobile.com/)
(...skipping 17 matching lines...) Expand all
28 * Boston, MA 02110-1301, USA. 28 * Boston, MA 02110-1301, USA.
29 */ 29 */
30 30
31 #include "core/css/resolver/StyleResolver.h" 31 #include "core/css/resolver/StyleResolver.h"
32 32
33 #include "core/CSSPropertyNames.h" 33 #include "core/CSSPropertyNames.h"
34 #include "core/HTMLNames.h" 34 #include "core/HTMLNames.h"
35 #include "core/MediaTypeNames.h" 35 #include "core/MediaTypeNames.h"
36 #include "core/StylePropertyShorthand.h" 36 #include "core/StylePropertyShorthand.h"
37 #include "core/animation/AnimationTimeline.h" 37 #include "core/animation/AnimationTimeline.h"
38 #include "core/animation/CSSInterpolationTypesMap.h"
38 #include "core/animation/ElementAnimations.h" 39 #include "core/animation/ElementAnimations.h"
39 #include "core/animation/InterpolationEnvironment.h" 40 #include "core/animation/InterpolationEnvironment.h"
40 #include "core/animation/InvalidatableInterpolation.h" 41 #include "core/animation/InvalidatableInterpolation.h"
41 #include "core/animation/KeyframeEffect.h" 42 #include "core/animation/KeyframeEffect.h"
42 #include "core/animation/StyleInterpolation.h" 43 #include "core/animation/StyleInterpolation.h"
43 #include "core/animation/animatable/AnimatableValue.h" 44 #include "core/animation/animatable/AnimatableValue.h"
44 #include "core/animation/css/CSSAnimatableValueFactory.h" 45 #include "core/animation/css/CSSAnimatableValueFactory.h"
45 #include "core/animation/css/CSSAnimations.h" 46 #include "core/animation/css/CSSAnimations.h"
46 #include "core/css/CSSCalculationValue.h" 47 #include "core/css/CSSCalculationValue.h"
47 #include "core/css/CSSCustomIdentValue.h" 48 #include "core/css/CSSCustomIdentValue.h"
(...skipping 1175 matching lines...) Expand 10 before | Expand all | Expand 10 after
1223 // they should instead apply in 1224 // they should instead apply in
1224 // SVGElement::collectStyleForPresentationAttribute(). 1225 // SVGElement::collectStyleForPresentationAttribute().
1225 for (const auto& entry : activeInterpolationsMap) { 1226 for (const auto& entry : activeInterpolationsMap) {
1226 CSSPropertyID property = entry.key.isCSSProperty() 1227 CSSPropertyID property = entry.key.isCSSProperty()
1227 ? entry.key.cssProperty() 1228 ? entry.key.cssProperty()
1228 : entry.key.presentationAttribute(); 1229 : entry.key.presentationAttribute();
1229 if (!CSSPropertyPriorityData<priority>::propertyHasPriority(property)) 1230 if (!CSSPropertyPriorityData<priority>::propertyHasPriority(property))
1230 continue; 1231 continue;
1231 const Interpolation& interpolation = *entry.value.front(); 1232 const Interpolation& interpolation = *entry.value.front();
1232 if (interpolation.isInvalidatableInterpolation()) { 1233 if (interpolation.isInvalidatableInterpolation()) {
1233 InterpolationEnvironment environment(state); 1234 CSSInterpolationTypesMap map(state.document().propertyRegistry());
1235 InterpolationEnvironment environment(map, state);
1234 InvalidatableInterpolation::applyStack(entry.value, environment); 1236 InvalidatableInterpolation::applyStack(entry.value, environment);
1235 } else { 1237 } else {
1236 // TODO(alancutter): Remove this old code path once animations have 1238 // TODO(alancutter): Remove this old code path once animations have
1237 // completely migrated to InterpolationTypes. 1239 // completely migrated to InterpolationTypes.
1238 toStyleInterpolation(interpolation).apply(state); 1240 toStyleInterpolation(interpolation).apply(state);
1239 } 1241 }
1240 } 1242 }
1241 } 1243 }
1242 1244
1243 static inline bool isValidCueStyleProperty(CSSPropertyID id) { 1245 static inline bool isValidCueStyleProperty(CSSPropertyID id) {
(...skipping 723 matching lines...) Expand 10 before | Expand all | Expand 10 after
1967 DEFINE_TRACE(StyleResolver) { 1969 DEFINE_TRACE(StyleResolver) {
1968 visitor->trace(m_matchedPropertiesCache); 1970 visitor->trace(m_matchedPropertiesCache);
1969 visitor->trace(m_selectorFilter); 1971 visitor->trace(m_selectorFilter);
1970 visitor->trace(m_styleSharingLists); 1972 visitor->trace(m_styleSharingLists);
1971 visitor->trace(m_pendingStyleSheets); 1973 visitor->trace(m_pendingStyleSheets);
1972 visitor->trace(m_document); 1974 visitor->trace(m_document);
1973 visitor->trace(m_tracker); 1975 visitor->trace(m_tracker);
1974 } 1976 }
1975 1977
1976 } // namespace blink 1978 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/css/PropertyRegistry.h ('k') | third_party/WebKit/Source/core/svg/SVGElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698