third_party/WebKit/Source/core/animation/Keyframe.cpp - Issue 2555923003: Make InvalidatableInterpolation's InterpolationTypes decided at effect application time

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/Keyframe.cpp

Issue 2555923003: Make InvalidatableInterpolation's InterpolationTypes decided at effect application time (Closed)

Patch Set: Extended InterpolationTypesMap lifetime scope to fix release crash Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/animation/Keyframe.cpp

diff --git a/third_party/WebKit/Source/core/animation/Keyframe.cpp b/third_party/WebKit/Source/core/animation/Keyframe.cpp

index 5c7333742c553428a8b8b9373cd004e86f151387..bf504e4afb74c1d47dfe094f5f3e10e51ff0f5e9 100644

--- a/third_party/WebKit/Source/core/animation/Keyframe.cpp

+++ b/third_party/WebKit/Source/core/animation/Keyframe.cpp

@@ -5,7 +5,6 @@

#include "core/animation/Keyframe.h"

#include "core/animation/InvalidatableInterpolation.h"

-#include "core/animation/PropertyInterpolationTypesMapping.h"

namespace blink {

@@ -15,8 +14,7 @@ Keyframe::PropertySpecificKeyframe::createInterpolation(

const Keyframe::PropertySpecificKeyframe& end) const {

// const_cast to take refs.

return InvalidatableInterpolation::create(

- propertyHandle, PropertyInterpolationTypesMapping::get(propertyHandle),

- const_cast<PropertySpecificKeyframe*>(this),

+ propertyHandle, const_cast<PropertySpecificKeyframe*>(this),

const_cast<PropertySpecificKeyframe*>(&end));

}