Remove enable_notifications build flag and define

chrome/test/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chrome_build.gni")
 import("//build/config/compiler/compiler.gni")
 import("//build/config/crypto.gni")
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//chrome/common/features.gni")
@@ skipping 365 matching lines @@
       "../browser/apps/app_browsertest_util.h",
       "../browser/apps/app_pointer_lock_interactive_uitest.cc",
       "../browser/apps/app_shim/app_shim_interactive_uitest_mac.mm",
       "../browser/apps/app_shim/app_shim_quit_interactive_uitest_mac.mm",
       "../browser/apps/app_window_interactive_uitest.cc",
       "../browser/apps/guest_view/web_view_interactive_browsertest.cc",
       "../browser/autofill/autofill_interactive_uitest.cc",
       "../browser/autofill/autofill_uitest_util.cc",
       "../browser/browser_keyevents_browsertest.cc",
       "../browser/extensions/api/extension_action/browser_action_interactive_test.cc",
+      "../browser/extensions/api/notifications/notifications_apitest.cc",
       "../browser/extensions/api/omnibox/omnibox_api_interactive_test.cc",
       "../browser/extensions/api/tabs/tabs_interactive_test.cc",
       "../browser/extensions/browsertest_util.cc",
       "../browser/extensions/chrome_extension_test_notification_observer.cc",
       "../browser/extensions/chrome_extension_test_notification_observer.h",
       "../browser/extensions/clipboard_extension_apitest_chromeos.cc",
       "../browser/extensions/extension_apitest.cc",
       "../browser/extensions/extension_browsertest.cc",
       "../browser/extensions/extension_commands_global_registry_apitest.cc",
       "../browser/extensions/extension_crash_recovery_browsertest.cc",
       "../browser/extensions/extension_fullscreen_apitest.cc",
       "../browser/extensions/extension_function_test_utils.cc",
       "../browser/extensions/extension_keybinding_apitest.cc",
       "../browser/extensions/updater/extension_cache_fake.cc",
       "../browser/extensions/updater/extension_cache_fake.h",
       "../browser/extensions/window_open_interactive_apitest.cc",
       "../browser/mouseleave_browsertest.cc",
+      "../browser/notifications/message_center_notifications_browsertest.cc",
       "../browser/password_manager/password_generation_interactive_uitest.cc",
       "../browser/password_manager/password_manager_interactive_uitest.cc",
       "../browser/renderer_context_menu/render_view_context_menu_browsertest_util.cc",
       "../browser/renderer_context_menu/render_view_context_menu_browsertest_util.h",
       "../browser/renderer_host/site_per_process_text_input_browsertest.cc",
       "../browser/site_per_process_interactive_browsertest.cc",
       "../browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc",
       "../browser/ui/blocked_content/popup_blocker_browsertest.cc",
       "../browser/ui/browser_focus_uitest.cc",
       "../browser/ui/cocoa/apps/app_shim_menu_controller_mac_interactive_uitest.mm",
@@ skipping 273 matching lines @@
           data_deps += [ "//components/nacl/loader:helper_nonsfi" ]
         }
       }
 
       if (is_chrome_branded) {
         sources -= [
           # These tests are failing on official cros bots. crbug.com/431450.
           "../browser/ui/views/bookmarks/bookmark_bar_view_test.cc",
         ]
       }
+    } else {  # ! is_chromeos
+      # Non-ChromeOS notifications tests (ChromeOS does not use cross-platform
+      # panels).
+      sources += [
+        "../browser/notifications/notification_interactive_uitest.cc",
+        "../browser/notifications/platform_notification_service_interactive_uitest.cc",
+      ]
     }
 
     if (is_win) {
       sources += [
         "../browser/downgrade/user_data_downgrade_browsertest.cc",
         "//ui/resources/cursors/aliasb.cur",
         "//ui/resources/cursors/cell.cur",
         "//ui/resources/cursors/col_resize.cur",
         "//ui/resources/cursors/copy.cur",
         "//ui/resources/cursors/none.cur",
@@ skipping 63 matching lines @@
       ]
       if (is_chromeos) {
         sources -= [
           # Use only the _chromeos version on ChromeOS.
           "base/view_event_test_platform_part_default.cc",
         ]
       }
       deps += [ "//ash/test:interactive_ui_test_support" ]
     }
 
-    if (enable_notifications) {
-      sources += [
-        "../browser/extensions/api/notifications/notifications_apitest.cc",
+    if (is_android) {
+      sources -= [
+        # Android does not use the message center-based Notification system.
         "../browser/notifications/message_center_notifications_browsertest.cc",
+
+        # TODO(peter): Enable the Notification browser tests.
+        "../browser/notifications/notification_interactive_uitest.cc",
+        "../browser/notifications/platform_notification_service_interactive_uitest.cc",
       ]
-
-      # Non-ChromeOS notifications tests (ChromeOS does not use cross-platform
-      # panels).
-      if (!is_chromeos) {
-        sources += [
-          "../browser/notifications/notification_interactive_uitest.cc",
-          "../browser/notifications/platform_notification_service_interactive_uitest.cc",
-        ]
-      }
-
-      if (is_android) {
-        sources -= [
-          # Android does not use the message center-based Notification system.
-          "../browser/notifications/message_center_notifications_browsertest.cc",
-
-          # TODO(peter): Enable the Notification browser tests.
-          "../browser/notifications/notification_interactive_uitest.cc",
-          "../browser/notifications/platform_notification_service_interactive_uitest.cc",
-        ]
-      }
-    }  # enable_notifications
+    }
 
     if (!use_aura || is_chromeos) {
       sources -= [ "//ui/views/corewm/desktop_capture_controller_unittest.cc" ]
     }
   }
 
   if (enable_app_list && use_ash) {
     static_library("test_support_applist_ash") {
       defines = []
       testonly = true
@@ skipping 2392 matching lines @@
     "../browser/net/net_error_tab_helper_unittest.cc",
     "../browser/net/predictor_unittest.cc",
     "../browser/net/probe_message_unittest.cc",
     "../browser/net/quota_policy_channel_id_store_unittest.cc",
     "../browser/net/safe_search_util_unittest.cc",
     "../browser/net/spdyproxy/chrome_data_use_group_provider_unittest.cc",
     "../browser/net/spdyproxy/chrome_data_use_group_unittest.cc",
     "../browser/net/spdyproxy/data_reduction_proxy_chrome_settings_unittest.cc",
     "../browser/net/spdyproxy/data_reduction_proxy_settings_unittest_android.cc",
     "../browser/net/url_info_unittest.cc",
+    "../browser/notifications/desktop_notification_profile_util_unittest.cc",
+    "../browser/notifications/notification_permission_context_unittest.cc",
+    "../browser/notifications/notification_platform_bridge_mac_unittest.mm",
+    "../browser/notifications/platform_notification_service_unittest.cc",
+    "../browser/notifications/stub_alert_dispatcher_mac.h",
+    "../browser/notifications/stub_alert_dispatcher_mac.mm",
+    "../browser/notifications/stub_notification_center_mac.h",
+    "../browser/notifications/stub_notification_center_mac.mm",
     "../browser/ntp_snippets/download_suggestions_provider_unittest.cc",
     "../browser/page_load_metrics/metrics_web_contents_observer_unittest.cc",
     "../browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc",
     "../browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc",
     "../browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc",
     "../browser/page_load_metrics/observers/document_write_page_load_metrics_observer_unittest.cc",
     "../browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc",
     "../browser/page_load_metrics/observers/google_captcha_observer_unittest.cc",
     "../browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc",
     "../browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.h",
@@ skipping 353 matching lines @@
       "../browser/media_galleries/media_galleries_dialog_controller_test_util.cc",
       "../browser/media_galleries/media_galleries_dialog_controller_test_util.h",
       "../browser/media_galleries/media_galleries_permission_controller_unittest.cc",
       "../browser/media_galleries/media_galleries_permissions_unittest.cc",
       "../browser/media_galleries/media_galleries_preferences_unittest.cc",
       "../browser/media_galleries/win/mtp_device_delegate_impl_win_unittest.cc",
       "../browser/media_galleries/win/mtp_device_object_enumerator_unittest.cc",
       "../browser/memory/tab_manager_delegate_chromeos_unittest.cc",
       "../browser/memory/tab_manager_unittest.cc",
       "../browser/memory/tab_manager_web_contents_data_unittest.cc",
+
+      # Android does not use the Message Center notification system.
       "../browser/net/firefox_proxy_settings_unittest.cc",
+      "../browser/notifications/message_center_notifications_unittest.cc",
+      "../browser/notifications/message_center_settings_controller_unittest.cc",
       "../browser/permissions/permission_request_manager_unittest.cc",
       "../browser/platform_util_unittest.cc",
       "../browser/power_usage_monitor/power_usage_monitor_unittest.cc",
       "../browser/process_singleton_posix_unittest.cc",
       "../browser/profile_resetter/profile_resetter_unittest.cc",
       "../browser/profile_resetter/triggered_profile_resetter_win_unittest.cc",
       "../browser/renderer_context_menu/render_view_context_menu_unittest.cc",
       "../browser/search/instant_service_unittest.cc",
       "../browser/search/instant_unittest_base.cc",
       "../browser/search/instant_unittest_base.h",
@@ skipping 591 matching lines @@
       "../browser/printing/cloud_print/privet_notifications_unittest.cc",
       "../browser/printing/cloud_print/privet_url_fetcher_unittest.cc",
     ]
   }
   if (enable_web_speech) {
     sources += [
       "../browser/speech/extension_api/extension_manifests_tts_unittest.cc",
       "../browser/speech/tts_controller_unittest.cc",
     ]
   }
-  if (enable_notifications) {
-    sources += [
-      "../browser/notifications/desktop_notification_profile_util_unittest.cc",
-      "../browser/notifications/message_center_notifications_unittest.cc",
-      "../browser/notifications/message_center_settings_controller_unittest.cc",
-      "../browser/notifications/notification_permission_context_unittest.cc",
-      "../browser/notifications/notification_platform_bridge_mac_unittest.mm",
-      "../browser/notifications/platform_notification_service_unittest.cc",
-      "../browser/notifications/stub_alert_dispatcher_mac.h",
-      "../browser/notifications/stub_alert_dispatcher_mac.mm",
-      "../browser/notifications/stub_notification_center_mac.h",
-      "../browser/notifications/stub_notification_center_mac.mm",
-    ]
-    if (is_android) {
-      sources -= [
-        # Android does not use the Message Center notification system.
-        "../browser/notifications/message_center_notifications_unittest.cc",
-        "../browser/notifications/message_center_settings_controller_unittest.cc",
-      ]
-    }
-  }
 
   if (safe_browsing_mode > 0) {
     sources += [
       "../browser/safe_browsing/certificate_reporting_service_unittest.cc",
       "../browser/safe_browsing/ping_manager_unittest.cc",
       "../browser/safe_browsing/safe_browsing_blocking_page_unittest.cc",
       "../browser/safe_browsing/threat_details_unittest.cc",
       "../browser/safe_browsing/ui_manager_unittest.cc",
       "../common/safe_browsing/file_type_policies_test_util.cc",
       "../common/safe_browsing/file_type_policies_test_util.h",
@@ skipping 913 matching lines @@
 }
 
 if (is_win) {
   loadable_module("conflicts_dll") {
     testonly = true
     sources = [
       "conflicts/conflicts_dll.cc",
     ]
   }
 }