Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2556883002: Remove enable_web_speech flag. (Closed)

Created:
4 years ago by brettw
Modified:
4 years ago
Reviewers:
sky
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove enable_web_speech flag. This flag is not overridable from the build. Its definition is non-mobile. Now that iOS is no longer compiled using chrome or content, all web speech conditions become non-Android and this flag can be removed. BUG=671706 Committed: https://crrev.com/24746e51329bde141ba7c4a1a39a94624381de6f Cr-Commit-Position: refs/heads/master@{#436860}

Patch Set 1 #

Patch Set 2 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -63 lines) Patch
M build/config/features.gni View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/BUILD.gn View 5 chunks +8 lines, -13 lines 0 comments Download
M content/browser/BUILD.gn View 4 chunks +17 lines, -33 lines 0 comments Download
M content/test/BUILD.gn View 4 chunks +11 lines, -15 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 22 (15 generated)
brettw
4 years ago (2016-12-06 20:55:17 UTC) #2
sky
LGTM
4 years ago (2016-12-06 21:12:50 UTC) #7
brettw
Merge
4 years ago (2016-12-06 21:21:04 UTC) #8
commit-bot: I haz the power
This CL has an open dependency (Issue 2555833002 Patch 20001). Please resolve the dependency and ...
4 years ago (2016-12-06 21:21:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2556883002/20001
4 years ago (2016-12-07 03:34:44 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-07 04:27:09 UTC) #20
commit-bot: I haz the power
4 years ago (2016-12-07 04:29:58 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/24746e51329bde141ba7c4a1a39a94624381de6f
Cr-Commit-Position: refs/heads/master@{#436860}

Powered by Google App Engine
This is Rietveld 408576698