Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1097)

Issue 2553343002: Avoid WTF::Vector::at() and operator[] in core/dom. (Closed)

Created:
4 years ago by tkent
Modified:
4 years ago
Reviewers:
hayato
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, dominicc+watchlist_chromium.org, eae+blinkwatch, Eric Willigers, rjwright, rwlbuis, shans, sof, webcomponents-bugzilla_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid WTF::Vector::at() and operator[] in core/dom. at() and operator[] are slow due to RELEASE_ASSERT. We can avoid the slowness by range-based |for|. This CL has no behavior changes except runtime performance. BUG=668300 Committed: https://crrev.com/a9f3df455d2ea2b360dda396e86df6fdff49dbe8 Cr-Commit-Position: refs/heads/master@{#436875}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -111 lines) Patch
M third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp View 3 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ClientRectList.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/CompositorProxy.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMStringList.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DOMTokenList.cpp View 4 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.cpp View 2 chunks +5 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/MutationObserver.cpp View 4 chunks +12 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 5 chunks +11 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptedAnimationController.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/SelectorQuery.cpp View 4 chunks +11 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/dom/SpaceSplitString.h View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.cpp View 3 chunks +8 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/V0CustomElementAsyncImportMicrotaskQueue.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/custom/V0CustomElementMicrotaskQueueBase.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ElementShadowV0.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/InsertionPoint.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
tkent
hayato@, would you review this please?
4 years ago (2016-12-07 04:57:46 UTC) #10
hayato
lgtm
4 years ago (2016-12-07 04:58:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553343002/20001
4 years ago (2016-12-07 05:49:13 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years ago (2016-12-07 05:53:44 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-07 05:57:55 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9f3df455d2ea2b360dda396e86df6fdff49dbe8
Cr-Commit-Position: refs/heads/master@{#436875}

Powered by Google App Engine
This is Rietveld 408576698