third_party/WebKit/Source/core/dom/custom/V0CustomElementMicrotaskQueueBase.cpp - Issue 2553343002: Avoid WTF::Vector::at() and operator[] in core/dom.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/V0CustomElementMicrotaskQueueBase.cpp

Issue 2553343002: Avoid WTF::Vector::at() and operator[] in core/dom. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/custom/V0CustomElementAsyncImportMicrotaskQueue.cpp ('k') | third_party/WebKit/Source/core/dom/shadow/ElementShadowV0.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/V0CustomElementMicrotaskQueueBase.cpp

diff --git a/third_party/WebKit/Source/core/dom/custom/V0CustomElementMicrotaskQueueBase.cpp b/third_party/WebKit/Source/core/dom/custom/V0CustomElementMicrotaskQueueBase.cpp

index 27f17ce351bbdde57799470f3a05bcc5447172b0..e6f7d0dae7e28f698e37bf2963ce27228b039108 100644

--- a/third_party/WebKit/Source/core/dom/custom/V0CustomElementMicrotaskQueueBase.cpp

+++ b/third_party/WebKit/Source/core/dom/custom/V0CustomElementMicrotaskQueueBase.cpp

@@ -21,9 +21,9 @@ DEFINE_TRACE(V0CustomElementMicrotaskQueueBase) {

#if !defined(NDEBUG)

void V0CustomElementMicrotaskQueueBase::show(unsigned indent) {

- for (unsigned q = 0; q < m_queue.size(); ++q) {

- if (m_queue[q])

- m_queue[q]->show(indent);

+ for (const auto& step : m_queue) {

+ if (step)

+ step->show(indent);

else

fprintf(stderr, "%*snull\n", indent, "");

}