Avoid WTF::Vector::at() and operator[] in core/dom.

third_party/WebKit/Source/core/dom/SelectorQuery.cpp

 /*
  * Copyright (C) 2011, 2013 Apple Inc. All rights reserved.
  * Copyright (C) 2014 Samsung Electronics. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 127 matching lines @@
       &element, SelectorChecker::VisitedMatchDisabled);
   context.selector = &selector;
   context.scope = &rootNode;
   return checker.match(context);
 }
 
 bool SelectorDataList::matches(Element& targetElement) const {
   if (m_needsUpdatedDistribution)
     targetElement.updateDistribution();
 
-  unsigned selectorCount = m_selectors.size();
-  for (unsigned i = 0; i < selectorCount; ++i) {
-    if (selectorMatches(*m_selectors[i], targetElement, targetElement))
+  for (const auto& selector : m_selectors) {
+    if (selectorMatches(*selector, targetElement, targetElement))
       return true;
   }
 
   return false;
 }
 
 Element* SelectorDataList::closest(Element& targetElement) const {
-  unsigned selectorCount = m_selectors.size();
-  if (!selectorCount)
+  if (m_selectors.size() == 0)
     return nullptr;
   if (m_needsUpdatedDistribution)
     targetElement.updateDistribution();
 
   for (Element* currentElement = &targetElement; currentElement;
        currentElement = currentElement->parentElement()) {
-    for (unsigned i = 0; i < selectorCount; ++i) {
-      if (selectorMatches(*m_selectors[i], *currentElement, targetElement))
+    for (const auto& selector : m_selectors) {
+      if (selectorMatches(*selector, *currentElement, targetElement))
         return currentElement;
     }
   }
   return nullptr;
 }
 
 StaticElementList* SelectorDataList::queryAll(ContainerNode& rootNode) const {
   HeapVector<Member<Element>> result;
   execute<AllElementsSelectorQueryTrait>(rootNode, result);
   return StaticElementList::adopt(result);
@@ skipping 224 matching lines @@
       }
     }
   }
 }
 
 template <typename SelectorQueryTrait>
 bool SelectorDataList::selectorListMatches(
     ContainerNode& rootNode,
     Element& element,
     typename SelectorQueryTrait::OutputType& output) const {
-  for (unsigned i = 0; i < m_selectors.size(); ++i) {
-    if (selectorMatches(*m_selectors[i], element, rootNode)) {
+  for (const auto& selector : m_selectors) {
+    if (selectorMatches(*selector, element, rootNode)) {
       SelectorQueryTrait::appendElement(output, element);
       return true;
     }
   }
   return false;
 }
 
 template <typename SelectorQueryTrait>
 void SelectorDataList::executeSlow(
     ContainerNode& rootNode,
@@ skipping 115 matching lines @@
   const CSSSelector& selector = *m_selectors[0];
   const CSSSelector& firstSelector = selector;
 
   // Fast path for querySelector*('#id'), querySelector*('tag#id'),
   // querySelector*('tag[id=example]').
   if (const CSSSelector* idSelector = selectorForIdLookup(firstSelector)) {
     const AtomicString& idToMatch = idSelector->value();
     if (rootNode.treeScope().containsMultipleElementsWithId(idToMatch)) {
       const HeapVector<Member<Element>>& elements =
           rootNode.treeScope().getAllElementsById(idToMatch);
-      size_t count = elements.size();
-      for (size_t i = 0; i < count; ++i) {
-        Element& element = *elements[i];
-        if (!(isTreeScopeRoot(rootNode) || element.isDescendantOf(&rootNode)))
+      for (const auto& element : elements) {
+        if (!(isTreeScopeRoot(rootNode) || element->isDescendantOf(&rootNode)))
           continue;
-        if (selectorMatches(selector, element, rootNode)) {
-          SelectorQueryTrait::appendElement(output, element);
+        if (selectorMatches(selector, *element, rootNode)) {
+          SelectorQueryTrait::appendElement(output, *element);
           if (SelectorQueryTrait::shouldOnlyMatchFirstElement)
             return;
         }
       }
       return;
     }
     Element* element = rootNode.treeScope().getElementById(idToMatch);
     if (!element ||
         !(isTreeScopeRoot(rootNode) || element->isDescendantOf(&rootNode)))
       return;
@@ skipping 79 matching lines @@
 
   return m_entries.add(selectors, SelectorQuery::adopt(std::move(selectorList)))
       .storedValue->value.get();
 }
 
 void SelectorQueryCache::invalidate() {
   m_entries.clear();
 }
 
 }  // namespace blink