third_party/WebKit/Source/core/dom/custom/V0CustomElementAsyncImportMicrotaskQueue.cpp - Issue 2553343002: Avoid WTF::Vector::at() and operator[] in core/dom.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/V0CustomElementAsyncImportMicrotaskQueue.cpp

Issue 2553343002: Avoid WTF::Vector::at() and operator[] in core/dom. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/TreeScopeStyleSheetCollection.cpp ('k') | third_party/WebKit/Source/core/dom/custom/V0CustomElementMicrotaskQueueBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/V0CustomElementAsyncImportMicrotaskQueue.cpp

diff --git a/third_party/WebKit/Source/core/dom/custom/V0CustomElementAsyncImportMicrotaskQueue.cpp b/third_party/WebKit/Source/core/dom/custom/V0CustomElementAsyncImportMicrotaskQueue.cpp

index 67b29afcbc229162e9caab281d23b0abed495555..a1061215b25cc947bac8ecf21b440f1c33383ab6 100644

--- a/third_party/WebKit/Source/core/dom/custom/V0CustomElementAsyncImportMicrotaskQueue.cpp

+++ b/third_party/WebKit/Source/core/dom/custom/V0CustomElementAsyncImportMicrotaskQueue.cpp

@@ -42,9 +42,9 @@ void V0CustomElementAsyncImportMicrotaskQueue::enqueue(

void V0CustomElementAsyncImportMicrotaskQueue::doDispatch() {

HeapVector<Member<V0CustomElementMicrotaskStep>> remaining;

- for (unsigned i = 0; i < m_queue.size(); ++i) {

- if (V0CustomElementMicrotaskStep::Processing == m_queue[i]->process())

- remaining.append(m_queue[i].release());

+ for (auto& step : m_queue) {

+ if (V0CustomElementMicrotaskStep::Processing == step->process())

+ remaining.append(step.release());

}

m_queue.swap(remaining);