Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2553263002: Remove code to defer app window appearance until first paint. (Closed)

Created:
4 years ago by jam
Modified:
4 years ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove code to defer app window appearance until first paint. This is effectively dead code since no one has worked to turn it on for two and a half years and chrome apps are deprecated. The current motivation is fixing PlatformAppBrowserTest.ActiveAppsAreRecorded with PlzNavigate, since the changes in r275132 made it not work with it (the test event comes too early with PlzNavigate). Instead of fixing this, I decided it's simpler to remove this code. BUG=225843, 504347, 671516 Committed: https://crrev.com/387b7142c3f6124c45afcceb60349479748d3c63 Cr-Commit-Position: refs/heads/master@{#436964}

Patch Set 1 #

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -153 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/tabs/ash_panel_contents.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/ash_panel_contents.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/active_test/test.js View 1 chunk +3 lines, -10 lines 0 comments Download
M extensions/browser/api/app_window/app_window_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/app_window/app_window.h View 5 chunks +0 lines, -21 lines 0 comments Download
M extensions/browser/app_window/app_window.cc View 1 11 chunks +0 lines, -60 lines 0 comments Download
M extensions/browser/app_window/app_window_contents.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/app_window/app_window_contents.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M extensions/browser/app_window/test_app_window_contents.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/app_window/test_app_window_contents.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/common/api/app_current_window_internal.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/common/api/app_window.idl View 2 chunks +0 lines, -4 lines 0 comments Download
M extensions/common/switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/common/switches.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M extensions/renderer/resources/app_window_custom_bindings.js View 4 chunks +0 lines, -21 lines 0 comments Download

Messages

Total messages: 23 (18 generated)
jam
4 years ago (2016-12-06 23:53:42 UTC) #12
benwells
lgtm
4 years ago (2016-12-07 04:49:13 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553263002/40001
4 years ago (2016-12-07 15:43:54 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years ago (2016-12-07 15:49:01 UTC) #21
commit-bot: I haz the power
4 years ago (2016-12-07 15:53:31 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/387b7142c3f6124c45afcceb60349479748d3c63
Cr-Commit-Position: refs/heads/master@{#436964}

Powered by Google App Engine
This is Rietveld 408576698