Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Side by Side Diff: extensions/browser/app_window/app_window_contents.h

Issue 2553263002: Remove code to defer app window appearance until first paint. (Closed)
Patch Set: nit Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_BROWSER_APP_WINDOW_APP_WINDOW_CONTENTS_H_ 5 #ifndef EXTENSIONS_BROWSER_APP_WINDOW_APP_WINDOW_CONTENTS_H_
6 #define EXTENSIONS_BROWSER_APP_WINDOW_APP_WINDOW_CONTENTS_H_ 6 #define EXTENSIONS_BROWSER_APP_WINDOW_APP_WINDOW_CONTENTS_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 21 matching lines...) Expand all
32 explicit AppWindowContentsImpl(AppWindow* host); 32 explicit AppWindowContentsImpl(AppWindow* host);
33 ~AppWindowContentsImpl() override; 33 ~AppWindowContentsImpl() override;
34 34
35 // AppWindowContents 35 // AppWindowContents
36 void Initialize(content::BrowserContext* context, 36 void Initialize(content::BrowserContext* context,
37 content::RenderFrameHost* creator_frame, 37 content::RenderFrameHost* creator_frame,
38 const GURL& url) override; 38 const GURL& url) override;
39 void LoadContents(int32_t creator_process_id) override; 39 void LoadContents(int32_t creator_process_id) override;
40 void NativeWindowChanged(NativeAppWindow* native_app_window) override; 40 void NativeWindowChanged(NativeAppWindow* native_app_window) override;
41 void NativeWindowClosed() override; 41 void NativeWindowClosed() override;
42 void DispatchWindowShownForTests() const override;
43 void OnWindowReady() override; 42 void OnWindowReady() override;
44 content::WebContents* GetWebContents() const override; 43 content::WebContents* GetWebContents() const override;
45 WindowController* GetWindowController() const override; 44 WindowController* GetWindowController() const override;
46 45
47 private: 46 private:
48 // content::WebContentsObserver 47 // content::WebContentsObserver
49 bool OnMessageReceived(const IPC::Message& message) override; 48 bool OnMessageReceived(const IPC::Message& message) override;
50 void ReadyToCommitNavigation(content::NavigationHandle* handle) override; 49 void ReadyToCommitNavigation(content::NavigationHandle* handle) override;
51 50
52 void UpdateDraggableRegions(const std::vector<DraggableRegion>& regions); 51 void UpdateDraggableRegions(const std::vector<DraggableRegion>& regions);
53 void SuspendRenderFrameHost(content::RenderFrameHost* rfh); 52 void SuspendRenderFrameHost(content::RenderFrameHost* rfh);
54 53
55 AppWindow* host_; // This class is owned by |host_| 54 AppWindow* host_; // This class is owned by |host_|
56 GURL url_; 55 GURL url_;
57 std::unique_ptr<content::WebContents> web_contents_; 56 std::unique_ptr<content::WebContents> web_contents_;
58 bool is_blocking_requests_; 57 bool is_blocking_requests_;
59 bool is_window_ready_; 58 bool is_window_ready_;
60 59
61 DISALLOW_COPY_AND_ASSIGN(AppWindowContentsImpl); 60 DISALLOW_COPY_AND_ASSIGN(AppWindowContentsImpl);
62 }; 61 };
63 62
64 } // namespace extensions 63 } // namespace extensions
65 64
66 #endif // EXTENSIONS_BROWSER_APP_WINDOW_APP_WINDOW_CONTENTS_H_ 65 #endif // EXTENSIONS_BROWSER_APP_WINDOW_APP_WINDOW_CONTENTS_H_
OLDNEW
« no previous file with comments | « extensions/browser/app_window/app_window.cc ('k') | extensions/browser/app_window/app_window_contents.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698