Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Side by Side Diff: chrome/browser/extensions/api/tabs/ash_panel_contents.h

Issue 2553263002: Remove code to defer app window appearance until first paint. (Closed)
Patch Set: nit Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/extensions/api/tabs/ash_panel_contents.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_API_TABS_ASH_PANEL_CONTENTS_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_API_TABS_ASH_PANEL_CONTENTS_H_
6 #define CHROME_BROWSER_EXTENSIONS_API_TABS_ASH_PANEL_CONTENTS_H_ 6 #define CHROME_BROWSER_EXTENSIONS_API_TABS_ASH_PANEL_CONTENTS_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 18 matching lines...) Expand all
29 ~AshPanelContents() override; 29 ~AshPanelContents() override;
30 30
31 // extensions::AppWindowContents 31 // extensions::AppWindowContents
32 void Initialize(content::BrowserContext* context, 32 void Initialize(content::BrowserContext* context,
33 content::RenderFrameHost* creator_frame, 33 content::RenderFrameHost* creator_frame,
34 const GURL& url) override; 34 const GURL& url) override;
35 void LoadContents(int32_t creator_process_id) override; 35 void LoadContents(int32_t creator_process_id) override;
36 void NativeWindowChanged( 36 void NativeWindowChanged(
37 extensions::NativeAppWindow* native_app_window) override; 37 extensions::NativeAppWindow* native_app_window) override;
38 void NativeWindowClosed() override; 38 void NativeWindowClosed() override;
39 void DispatchWindowShownForTests() const override;
40 void OnWindowReady() override; 39 void OnWindowReady() override;
41 content::WebContents* GetWebContents() const override; 40 content::WebContents* GetWebContents() const override;
42 extensions::WindowController* GetWindowController() const override; 41 extensions::WindowController* GetWindowController() const override;
43 42
44 // LauncherFaviconLoader::Delegate overrides: 43 // LauncherFaviconLoader::Delegate overrides:
45 void FaviconUpdated() override; 44 void FaviconUpdated() override;
46 45
47 LauncherFaviconLoader* launcher_favicon_loader_for_test() { 46 LauncherFaviconLoader* launcher_favicon_loader_for_test() {
48 return launcher_favicon_loader_.get(); 47 return launcher_favicon_loader_.get();
49 } 48 }
50 49
51 private: 50 private:
52 extensions::AppWindow* host_; 51 extensions::AppWindow* host_;
53 GURL url_; 52 GURL url_;
54 std::unique_ptr<content::WebContents> web_contents_; 53 std::unique_ptr<content::WebContents> web_contents_;
55 std::unique_ptr<LauncherFaviconLoader> launcher_favicon_loader_; 54 std::unique_ptr<LauncherFaviconLoader> launcher_favicon_loader_;
56 55
57 DISALLOW_COPY_AND_ASSIGN(AshPanelContents); 56 DISALLOW_COPY_AND_ASSIGN(AshPanelContents);
58 }; 57 };
59 58
60 #endif // CHROME_BROWSER_EXTENSIONS_API_TABS_ASH_PANEL_CONTENTS_H_ 59 #endif // CHROME_BROWSER_EXTENSIONS_API_TABS_ASH_PANEL_CONTENTS_H_
OLDNEW
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/extensions/api/tabs/ash_panel_contents.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698