Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Unified Diff: extensions/browser/app_window/app_window.h

Issue 2553263002: Remove code to defer app window appearance until first paint. (Closed)
Patch Set: nit Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/api/app_window/app_window_api.cc ('k') | extensions/browser/app_window/app_window.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/app_window/app_window.h
diff --git a/extensions/browser/app_window/app_window.h b/extensions/browser/app_window/app_window.h
index fdf51c2aed657d4528761e71ab768cce4cffe34c..66fdd4c1417d283093f447fb63943f384f6577b0 100644
--- a/extensions/browser/app_window/app_window.h
+++ b/extensions/browser/app_window/app_window.h
@@ -71,9 +71,6 @@ class AppWindowContents {
// Called when the native window closes.
virtual void NativeWindowClosed() = 0;
- // Called in tests when the window is shown
- virtual void DispatchWindowShownForTests() const = 0;
-
// Called when the renderer notifies the browser that the window is ready.
virtual void OnWindowReady() = 0;
@@ -359,10 +356,6 @@ class AppWindow : public content::WebContentsDelegate,
// the renderer.
void GetSerializedState(base::DictionaryValue* properties) const;
- // Called by the window API when events can be sent to the window for this
- // app.
- void WindowEventsReady();
-
// Notifies the window's contents that the render view is ready and it can
// unblock resource requests.
void NotifyRenderViewReady();
@@ -446,7 +439,6 @@ class AppWindow : public content::WebContentsDelegate,
// content::WebContentsObserver implementation.
void RenderViewCreated(content::RenderViewHost* render_view_host) override;
- void DidFirstVisuallyNonEmptyPaint() override;
// ExtensionFunctionDispatcher::Delegate implementation.
WindowController* GetExtensionWindowController() const override;
@@ -545,19 +537,9 @@ class AppWindow : public content::WebContentsDelegate,
// Bit field of FullscreenType.
int fullscreen_types_;
- // Show has been called, so the window should be shown once the first visually
- // non-empty paint occurs.
- bool show_on_first_paint_;
-
- // The first visually non-empty paint has completed.
- bool first_paint_complete_;
-
// Whether the window has been shown or not.
bool has_been_shown_;
- // Whether events can be sent to the window.
- bool can_send_events_;
-
// Whether the window is hidden or not. Hidden in this context means actively
// by the chrome.app.window API, not in an operating system context. For
// example windows which are minimized are not hidden, and windows which are
@@ -566,9 +548,6 @@ class AppWindow : public content::WebContentsDelegate,
// hidden, are considered hidden.
bool is_hidden_;
- // Whether the delayed Show() call was for an active or inactive window.
- ShowType delayed_show_type_;
-
// Cache the desired value of the always-on-top property. When windows enter
// fullscreen or overlap the Windows taskbar, this property will be
// automatically and silently switched off for security reasons. It is
« no previous file with comments | « extensions/browser/api/app_window/app_window_api.cc ('k') | extensions/browser/app_window/app_window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698