Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2553253002: [Android History] Add support for opening items (Closed)

Created:
4 years ago by Theresa
Modified:
4 years ago
Reviewers:
gone
CC:
chromium-reviews, browser-components-watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android History] Add support for opening items BUG=654071 Committed: https://crrev.com/3ba7a94420937d5ee40e62afbb0d730a7f751f89 Cr-Commit-Position: refs/heads/master@{#437140}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Changes from dfalcantara@ review #

Messages

Total messages: 19 (13 generated)
Theresa
ptal - this one is reliant on the other patch I sent you. No rush.
4 years ago (2016-12-06 22:00:48 UTC) #4
gone
lgtm https://codereview.chromium.org/2553253002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItemView.java File chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItemView.java (right): https://codereview.chromium.org/2553253002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItemView.java#newcode36 chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItemView.java:36: mItem = item; Does it make sense to ...
4 years ago (2016-12-07 22:06:20 UTC) #7
Theresa
https://codereview.chromium.org/2553253002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItemView.java File chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItemView.java (right): https://codereview.chromium.org/2553253002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItemView.java#newcode36 chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItemView.java:36: mItem = item; On 2016/12/07 22:06:20, dfalcantara (check my ...
4 years ago (2016-12-07 23:56:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2553253002/20001
4 years ago (2016-12-08 01:59:36 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-08 02:07:29 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-08 02:12:30 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3ba7a94420937d5ee40e62afbb0d730a7f751f89
Cr-Commit-Position: refs/heads/master@{#437140}

Powered by Google App Engine
This is Rietveld 408576698