chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItemView.java - Issue 2553253002: [Android History] Add support for opening items

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItemView.java

Issue 2553253002: [Android History] Add support for opening items (Closed)

Patch Set: Changes from dfalcantara@ review Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItem.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItemView.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItemView.java b/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItemView.java

index d486f36f549b7af00c1ce49cb17576565887b8b4..f0dc825f3127ecce516f209ce066da8b2bcb3182 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItemView.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItemView.java

@@ -36,8 +36,15 @@ public class HistoryItemView extends SelectableItemView<HistoryItem> {

mDomain.setText(item.getDomain());

}

+ /**

+ * @param manager The HistoryManager associated with this item.

+ */

+ public void setHistoryManager(HistoryManager manager) {

+ getItem().setHistoryManager(manager);

+ }

@Override

protected void onClick() {

- // TODO(twellington): Handle clicks on the HistoryItemView.

+ if (getItem() != null) getItem().open();

}