[Android History] Add basic tablet support

[Android History] Add basic tablet support

BUG=654071
Committed: https://crrev.com/c3d5b3984f26d77db5042b7218404052c1ad4e7a
Cr-Commit-Position: refs/heads/master@{#437128}

[Theresa, 2016-12-06 18:54:35]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[Theresa, 2016-12-06 18:54:45]

twellington@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Theresa, 2016-12-06 18:54:46]

ptal

[commit-bot: I haz the power, 2016-12-06 18:55:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 19:56:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 19:56:25]

Dry run: This issue passed the CQ dry run.

[gone, 2016-12-07 21:52:54]

lgtm

https://codereview.chromium.org/2552353002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/UrlConstants.java
(right):

https://codereview.chromium.org/2552353002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/UrlConstants.java:34: public
static final String HISTORY_HOST = "history";
Might make sense to break the groups apart with newlines, at this point.  That
seems to be how they're ordered, anyway.

https://codereview.chromium.org/2552353002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManagerUtils.java
(right):

https://codereview.chromium.org/2552353002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManagerUtils.java:57:
//History shows up as a tab on tablets.
// History

https://codereview.chromium.org/2552353002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManagerUtils.java:62:
intent.setClass(activity.getApplicationContext(), HistoryActivity.class);
You've already got the application context above, right?

[Theresa, 2016-12-07 22:43:22]

https://codereview.chromium.org/2552353002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/UrlConstants.java
(right):

https://codereview.chromium.org/2552353002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/UrlConstants.java:34: public
static final String HISTORY_HOST = "history";
On 2016/12/07 21:52:54, dfalcantara (check my queue) wrote:
> Might make sense to break the groups apart with newlines, at this point.  That
> seems to be how they're ordered, anyway.

Done.

https://codereview.chromium.org/2552353002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManagerUtils.java
(right):

https://codereview.chromium.org/2552353002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManagerUtils.java:57:
//History shows up as a tab on tablets.
On 2016/12/07 21:52:54, dfalcantara (check my queue) wrote:
> // History

Done.

https://codereview.chromium.org/2552353002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryManagerUtils.java:62:
intent.setClass(activity.getApplicationContext(), HistoryActivity.class);
On 2016/12/07 21:52:54, dfalcantara (check my queue) wrote:
> You've already got the application context above, right?

Done.

[Theresa, 2016-12-07 22:43:26]

The CQ bit was checked by twellington@chromium.org

[Theresa, 2016-12-07 22:43:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2552353002/#ps20001
(title: "Address dfalcantara@ comments")

[commit-bot: I haz the power, 2016-12-07 22:43:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 01:50:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481150606835020,
"parent_rev": "3a9dd0217a46a3ac9b857c97b29dc091baf14e97", "commit_rev":
"62369fddc67c1c38fb457ee7c4c53855a8e3e7ba"}

[commit-bot: I haz the power, 2016-12-08 01:51:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-08 01:53:00]

Description was changed from

==========
[Android History] Add basic tablet support

BUG=654071
==========

to

==========
[Android History] Add basic tablet support

BUG=654071

Committed: https://crrev.com/c3d5b3984f26d77db5042b7218404052c1ad4e7a
Cr-Commit-Position: refs/heads/master@{#437128}
==========

[commit-bot: I haz the power, 2016-12-08 01:53:02]

Patchset 2 (id:??) landed as
https://crrev.com/c3d5b3984f26d77db5042b7218404052c1ad4e7a
Cr-Commit-Position: refs/heads/master@{#437128}