[Android History] Add support for removing items

[Android History] Add support for removing items

BUG=654071
Committed: https://crrev.com/f8c16ab19d3a79c00b7b66415f95f3bb40cd0615
Cr-Commit-Position: refs/heads/master@{#437378}

[Theresa, 2016-12-07 19:50:52]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 19:51:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 21:06:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 21:06:42]

Dry run: This issue passed the CQ dry run.

[Theresa, 2016-12-08 00:28:53]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[Theresa, 2016-12-08 00:29:14]

twellington@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Theresa, 2016-12-08 00:29:15]

ptal

[commit-bot: I haz the power, 2016-12-08 00:29:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 00:33:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 00:33:13]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Theresa, 2016-12-08 00:33:36]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 00:34:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 01:24:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 01:24:52]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[gone, 2016-12-08 21:21:56]

lgtm

https://codereview.chromium.org/2555273002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/history/BrowsingHistoryBridge.java
(right):

https://codereview.chromium.org/2555273002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/history/BrowsingHistoryBridge.java:21:
* Called after BrowsingHistoryBridge#queryHistory() is complete.
{@link Browsingetcetc#whatever()}

https://codereview.chromium.org/2555273002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/history/BrowsingHistoryBridge.java:36:
private final BrowsingHistoryObserver mObserver;
private final above regular private

https://codereview.chromium.org/2555273002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/history/BrowsingHistoryBridge.java:65:
* until #removeItems() is called.
{@link}

https://codereview.chromium.org/2555273002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/history/BrowsingHistoryBridge.java:68:
public void markItemForRemoval(HistoryItem item) {
Should this check for the pointer still being valid?

https://codereview.chromium.org/2555273002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItem.java
(right):

https://codereview.chromium.org/2555273002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItem.java:13:

one less newline?

https://codereview.chromium.org/2555273002/diff/40001/chrome/browser/android/...
File chrome/browser/android/history/browsing_history_bridge.cc (right):

https://codereview.chromium.org/2555273002/diff/40001/chrome/browser/android/...
chrome/browser/android/history/browsing_history_bridge.cc:102: new
BrowsingHistoryService::HistoryEntry());
git cl format?

[Theresa, 2016-12-08 21:51:15]

https://codereview.chromium.org/2555273002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/history/BrowsingHistoryBridge.java
(right):

https://codereview.chromium.org/2555273002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/history/BrowsingHistoryBridge.java:21:
* Called after BrowsingHistoryBridge#queryHistory() is complete.
On 2016/12/08 21:21:56, dfalcantara (check my queue) wrote:
> {@link Browsingetcetc#whatever()}

Done.

https://codereview.chromium.org/2555273002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/history/BrowsingHistoryBridge.java:36:
private final BrowsingHistoryObserver mObserver;
On 2016/12/08 21:21:56, dfalcantara (check my queue) wrote:
> private final above regular private

Done.

https://codereview.chromium.org/2555273002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/history/BrowsingHistoryBridge.java:65:
* until #removeItems() is called.
On 2016/12/08 21:21:56, dfalcantara (check my queue) wrote:
> {@link}

Done.

https://codereview.chromium.org/2555273002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/history/BrowsingHistoryBridge.java:68:
public void markItemForRemoval(HistoryItem item) {
On 2016/12/08 21:21:56, dfalcantara (check my queue) wrote:
> Should this check for the pointer still being valid?

I don't think it needs to -- the pointer only gets set to 0 when the activity or
native page is destroyed.

https://codereview.chromium.org/2555273002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItem.java
(right):

https://codereview.chromium.org/2555273002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/history/HistoryItem.java:13:

On 2016/12/08 21:21:56, dfalcantara (check my queue) wrote:
> one less newline?

Done.

https://codereview.chromium.org/2555273002/diff/40001/chrome/browser/android/...
File chrome/browser/android/history/browsing_history_bridge.cc (right):

https://codereview.chromium.org/2555273002/diff/40001/chrome/browser/android/...
chrome/browser/android/history/browsing_history_bridge.cc:102: new
BrowsingHistoryService::HistoryEntry());
On 2016/12/08 21:21:56, dfalcantara (check my queue) wrote:
> git cl format?

Done.

[Theresa, 2016-12-08 21:51:21]

The CQ bit was checked by twellington@chromium.org to run a CQ dry run

[Theresa, 2016-12-08 21:51:46]

The CQ bit was unchecked by twellington@chromium.org

[commit-bot: I haz the power, 2016-12-08 21:51:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Theresa, 2016-12-08 21:53:59]

The CQ bit was checked by twellington@chromium.org

[Theresa, 2016-12-08 21:53:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2555273002/#ps60001
(title: "Changes from dfalcantara@ review")

[commit-bot: I haz the power, 2016-12-08 21:54:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 22:48:00]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481234039325850,
"parent_rev": "28abc0223dd800aac850f948ed8d231220082528", "commit_rev":
"6520eff8fa72d5b4c239675909f5745526dbedd5"}

[commit-bot: I haz the power, 2016-12-08 22:48:28]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-08 22:52:29]

Description was changed from

==========
[Android History] Add support for removing items

BUG=654071
==========

to

==========
[Android History] Add support for removing items

BUG=654071

Committed: https://crrev.com/f8c16ab19d3a79c00b7b66415f95f3bb40cd0615
Cr-Commit-Position: refs/heads/master@{#437378}
==========

[commit-bot: I haz the power, 2016-12-08 22:52:30]

Patchset 4 (id:??) landed as
https://crrev.com/f8c16ab19d3a79c00b7b66415f95f3bb40cd0615
Cr-Commit-Position: refs/heads/master@{#437378}