Rename activeDOMObjectsAreStopped to isContextDestroyed

Rename activeDOMObjectsAreStopped to isContextDestroyed

ExecutionContext::activeDOMObjectsAreStopped returns if ExecutionContext::contextDestroyed
has been called or not. It should be renamed to ExecutionContext::isContextDestroyed.

BUG=610176
Committed: https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888
Cr-Commit-Position: refs/heads/master@{#436568}

[haraken, 2016-12-06 06:08:37]

haraken@chromium.org changed reviewers:
+ dcheng@chromium.org

[haraken, 2016-12-06 06:08:38]

PTAL

[dcheng, 2016-12-06 07:48:40]

LGTM

I kind of wish we could get rid of this function altogether: a few weeks ago, I
tried (https://codereview.chromium.org/2433773006/) but it turns out a few
things depend on the distinction.

Realistically, I think it could be fixable if we did two things:
- Null out context before dispatching to contextDestroyed().
- Passed the destroyed context as an argument to contextDestroyed()

Maybe something for the future?

[haraken, 2016-12-06 08:05:10]

On 2016/12/06 07:48:40, dcheng wrote:
> LGTM
> 
> I kind of wish we could get rid of this function altogether: a few weeks ago,
I
> tried (https://codereview.chromium.org/2433773006/) but it turns out a few
> things depend on the distinction.

Yeah, I want to remove the function.

> Realistically, I think it could be fixable if we did two things:
> - Null out context before dispatching to contextDestroyed().
> - Passed the destroyed context as an argument to contextDestroyed()
> 
> Maybe something for the future?

Good idea. It will be a lot of work since many contextDestroyed()s are heavily
relying on getExecutionContext(), but it's worth a try :)

[haraken, 2016-12-06 08:05:16]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-12-06 08:05:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 10:59:58]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481011516586360, "parent_rev":
"1eb974ce5378424ac80378bfe95c672c3dca2f96", "commit_rev":
"77f0b7ba71d4e616197cd4f78934707c4d35ad98"}

[commit-bot: I haz the power, 2016-12-06 11:00:24]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-06 11:03:03]

Description was changed from

==========
Rename activeDOMObjectsAreStopped to isContextDestroyed

ExecutionContext::activeDOMObjectsAreStopped returns if
ExecutionContext::contextDestroyed
has been called or not. It should be renamed to
ExecutionContext::isContextDestroyed.

BUG=610176
==========

to

==========
Rename activeDOMObjectsAreStopped to isContextDestroyed

ExecutionContext::activeDOMObjectsAreStopped returns if
ExecutionContext::contextDestroyed
has been called or not. It should be renamed to
ExecutionContext::isContextDestroyed.

BUG=610176

Committed: https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888
Cr-Commit-Position: refs/heads/master@{#436568}
==========

[commit-bot: I haz the power, 2016-12-06 11:03:04]

Patchset 1 (id:??) landed as
https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888
Cr-Commit-Position: refs/heads/master@{#436568}