third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp - Issue 2552993002: Rename activeDOMObjectsAreStopped to isContextDestroyed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp

Issue 2552993002: Rename activeDOMObjectsAreStopped to isContextDestroyed (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptPromiseProperty.h ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp

index 6446e1ea8bcd3d5892349500e40342bbd01af2ea..16b5739114257ec71b38d72d07a4b2da12cbd876 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp

@@ -375,9 +375,8 @@ TEST_F(ScriptPromisePropertyGarbageCollectedTest, Resolve_DeadContext) {

}

destroyContext();

- EXPECT_TRUE(

- !getProperty()->getExecutionContext() ||

- getProperty()->getExecutionContext()->activeDOMObjectsAreStopped());

+ EXPECT_TRUE(!getProperty()->getExecutionContext() ||

+ getProperty()->getExecutionContext()->isContextDestroyed());

getProperty()->resolve(new GarbageCollectedScriptWrappable("value"));

EXPECT_EQ(Property::Pending, getProperty()->getState());