third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerWindowClientCallback.cpp - Issue 2552993002: Rename activeDOMObjectsAreStopped to isContextDestroyed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerWindowClientCallback.cpp

Issue 2552993002: Rename activeDOMObjectsAreStopped to isContextDestroyed (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp ('k') | third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerWindowClientCallback.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerWindowClientCallback.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerWindowClientCallback.cpp

index b822eb7be0155159721be346462fca5483a3334e..4bd5ba31146dd099dd0394d648b46bae322ae711 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerWindowClientCallback.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerWindowClientCallback.cpp

@@ -15,7 +15,7 @@ namespace blink {

void NavigateClientCallback::onSuccess(

std::unique_ptr<WebServiceWorkerClientInfo> clientInfo) {

if (!m_resolver->getExecutionContext() ||

- m_resolver->getExecutionContext()->activeDOMObjectsAreStopped())

+ m_resolver->getExecutionContext()->isContextDestroyed())

return;

m_resolver->resolve(ServiceWorkerWindowClient::take(

m_resolver.get(), wrapUnique(clientInfo.release())));

@@ -23,7 +23,7 @@ void NavigateClientCallback::onSuccess(

void NavigateClientCallback::onError(const WebServiceWorkerError& error) {

if (!m_resolver->getExecutionContext() ||

- m_resolver->getExecutionContext()->activeDOMObjectsAreStopped())

+ m_resolver->getExecutionContext()->isContextDestroyed())

return;

if (error.errorType == WebServiceWorkerError::ErrorTypeNavigation) {