third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp - Issue 2552993002: Rename activeDOMObjectsAreStopped to isContextDestroyed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp

Issue 2552993002: Rename activeDOMObjectsAreStopped to isContextDestroyed (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp ('k') | third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp b/third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp

index 21cd0d9c22bd68dd44947c440f8390409e47ce07..9d053ddb7418123c015d5eb228489ea01afd66b4 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp

@@ -151,8 +151,7 @@ void V8V0CustomElementLifecycleCallbacks::created(Element* element) {

// FIXME: callbacks while paused should be queued up for execution to

// continue then be delivered in order rather than delivered immediately.

// Bug 329665 tracks similar behavior for other synchronous events.

- if (!getExecutionContext() ||

- getExecutionContext()->activeDOMObjectsAreStopped())

+ if (!getExecutionContext() || getExecutionContext()->isContextDestroyed())

return;

if (!m_scriptState->contextIsValid())

@@ -202,8 +201,7 @@ void V8V0CustomElementLifecycleCallbacks::attributeChanged(

// FIXME: callbacks while paused should be queued up for execution to

// continue then be delivered in order rather than delivered immediately.

// Bug 329665 tracks similar behavior for other synchronous events.

- if (!getExecutionContext() ||

- getExecutionContext()->activeDOMObjectsAreStopped())

+ if (!getExecutionContext() || getExecutionContext()->isContextDestroyed())

return;

if (!m_scriptState->contextIsValid())

@@ -238,8 +236,7 @@ void V8V0CustomElementLifecycleCallbacks::call(

// FIXME: callbacks while paused should be queued up for execution to

// continue then be delivered in order rather than delivered immediately.

// Bug 329665 tracks similar behavior for other synchronous events.

- if (!getExecutionContext() ||

- getExecutionContext()->activeDOMObjectsAreStopped())

+ if (!getExecutionContext() || getExecutionContext()->isContextDestroyed())

return;

if (!m_scriptState->contextIsValid())