Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 2552353002: [Android History] Add basic tablet support (Closed)
Patch Set: Address dfalcantara@ comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/UrlConstants.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser; 5 package org.chromium.chrome.browser;
6 6
7 import android.annotation.SuppressLint; 7 import android.annotation.SuppressLint;
8 import android.annotation.TargetApi; 8 import android.annotation.TargetApi;
9 import android.app.Activity; 9 import android.app.Activity;
10 import android.app.SearchManager; 10 import android.app.SearchManager;
(...skipping 1665 matching lines...) Expand 10 before | Expand all | Expand 10 after
1676 currentTab.stopLoading(); 1676 currentTab.stopLoading();
1677 RecordUserAction.record("MobileMenuStop"); 1677 RecordUserAction.record("MobileMenuStop");
1678 } else { 1678 } else {
1679 currentTab.reload(); 1679 currentTab.reload();
1680 RecordUserAction.record("MobileMenuReload"); 1680 RecordUserAction.record("MobileMenuReload");
1681 } 1681 }
1682 } else if (id == R.id.info_menu_id) { 1682 } else if (id == R.id.info_menu_id) {
1683 WebsiteSettingsPopup.show( 1683 WebsiteSettingsPopup.show(
1684 this, currentTab, null, WebsiteSettingsPopup.OPENED_FROM_MEN U); 1684 this, currentTab, null, WebsiteSettingsPopup.OPENED_FROM_MEN U);
1685 } else if (id == R.id.open_history_menu_id) { 1685 } else if (id == R.id.open_history_menu_id) {
1686 if (!HistoryManagerUtils.showHistoryManager(this)) { 1686 if (!HistoryManagerUtils.showHistoryManager(this, currentTab)) {
1687 currentTab.loadUrl( 1687 currentTab.loadUrl(
1688 new LoadUrlParams(UrlConstants.HISTORY_URL, PageTransiti on.AUTO_TOPLEVEL)); 1688 new LoadUrlParams(UrlConstants.HISTORY_URL, PageTransiti on.AUTO_TOPLEVEL));
1689 } 1689 }
1690 RecordUserAction.record("MobileMenuHistory"); 1690 RecordUserAction.record("MobileMenuHistory");
1691 StartupMetrics.getInstance().recordOpenedHistory(); 1691 StartupMetrics.getInstance().recordOpenedHistory();
1692 } else if (id == R.id.share_menu_id || id == R.id.direct_share_menu_id) { 1692 } else if (id == R.id.share_menu_id || id == R.id.direct_share_menu_id) {
1693 onShareMenuItemSelected(id == R.id.direct_share_menu_id, 1693 onShareMenuItemSelected(id == R.id.direct_share_menu_id,
1694 getCurrentTabModel().isIncognito()); 1694 getCurrentTabModel().isIncognito());
1695 } else if (id == R.id.print_id) { 1695 } else if (id == R.id.print_id) {
1696 PrintingController printingController = PrintingControllerImpl.getIn stance(); 1696 PrintingController printingController = PrintingControllerImpl.getIn stance();
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
1933 "Android.MultiWindowMode.IsTabletScreenWidthBelow600", 1933 "Android.MultiWindowMode.IsTabletScreenWidthBelow600",
1934 mScreenWidthDp < DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP); 1934 mScreenWidthDp < DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP);
1935 1935
1936 if (mScreenWidthDp < DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP) { 1936 if (mScreenWidthDp < DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP) {
1937 RecordHistogram.recordLinearCountHistogram( 1937 RecordHistogram.recordLinearCountHistogram(
1938 "Android.MultiWindowMode.TabletScreenWidth", mScreenWidthDp, 1, 1938 "Android.MultiWindowMode.TabletScreenWidth", mScreenWidthDp, 1,
1939 DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP, 50); 1939 DeviceFormFactor.MINIMUM_TABLET_WIDTH_DP, 50);
1940 } 1940 }
1941 } 1941 }
1942 } 1942 }
OLDNEW
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/UrlConstants.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698