Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5050)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java

Issue 2552353002: [Android History] Add basic tablet support (Closed)
Patch Set: Address dfalcantara@ comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java
index 5d8e1eb2c018a21512cba2bfa56545512d98025c..f7961a259d445b1e0e56b45160889d0fd87f0bad 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NativePageFactory.java
@@ -14,6 +14,7 @@ import org.chromium.chrome.browser.NativePage;
import org.chromium.chrome.browser.UrlConstants;
import org.chromium.chrome.browser.bookmarks.BookmarkPage;
import org.chromium.chrome.browser.download.DownloadPage;
+import org.chromium.chrome.browser.history.HistoryPage;
import org.chromium.chrome.browser.physicalweb.PhysicalWebDiagnosticsPage;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.chrome.browser.tabmodel.TabModelSelector;
@@ -46,6 +47,10 @@ public class NativePageFactory {
return new DownloadPage(activity, tab);
}
+ protected NativePage buildHistoryPage(Activity activity, Tab tab) {
+ return new HistoryPage(activity, tab);
+ }
+
protected NativePage buildRecentTabsPage(Activity activity, Tab tab) {
RecentTabsManager recentTabsManager =
new RecentTabsManager(tab, tab.getProfile(), activity);
@@ -58,7 +63,7 @@ public class NativePageFactory {
}
enum NativePageType {
- NONE, CANDIDATE, NTP, BOOKMARKS, RECENT_TABS, PHYSICAL_WEB, DOWNLOADS,
+ NONE, CANDIDATE, NTP, BOOKMARKS, RECENT_TABS, PHYSICAL_WEB, DOWNLOADS, HISTORY,
}
private static NativePageType nativePageType(String url, NativePage candidatePage,
@@ -81,6 +86,8 @@ public class NativePageFactory {
return NativePageType.BOOKMARKS;
} else if (UrlConstants.DOWNLOADS_HOST.equals(host)) {
return NativePageType.DOWNLOADS;
+ } else if (UrlConstants.HISTORY_HOST.equals(host)) {
+ return NativePageType.HISTORY;
} else if (UrlConstants.RECENT_TABS_HOST.equals(host) && !isIncognito) {
return NativePageType.RECENT_TABS;
} else if (UrlConstants.PHYSICAL_WEB_DIAGNOSTICS_HOST.equals(host)) {
@@ -133,6 +140,9 @@ public class NativePageFactory {
case DOWNLOADS:
page = sNativePageBuilder.buildDownloadsPage(activity, tab);
break;
+ case HISTORY:
+ page = sNativePageBuilder.buildHistoryPage(activity, tab);
+ break;
case RECENT_TABS:
page = sNativePageBuilder.buildRecentTabsPage(activity, tab);
break;
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/history/HistoryPage.java ('k') | chrome/android/java_sources.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698