Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2551723002: Replace unique_ptr.reset/release with std::move under src/extensions (Closed)

Created:
4 years ago by Sunny
Modified:
4 years ago
Reviewers:
Finnur
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace unique_ptr.reset/release with std::move under src/extensions BUG=644626 Committed: https://crrev.com/512baf2600a896850c67096fe148d63dbabf0c58 Cr-Commit-Position: refs/heads/master@{#437542}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M extensions/browser/api/alarms/alarm_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/cast_channel/cast_message_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/networking_private/networking_private_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/networking_private/networking_private_delegate_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/updater/request_queue_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/user_script_loader.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Sunny
PTAL, thanks~
4 years ago (2016-12-09 09:48:43 UTC) #3
Finnur
LGTM
4 years ago (2016-12-09 14:02:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2551723002/1
4 years ago (2016-12-09 14:29:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 15:18:52 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-09 15:20:29 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/512baf2600a896850c67096fe148d63dbabf0c58
Cr-Commit-Position: refs/heads/master@{#437542}

Powered by Google App Engine
This is Rietveld 408576698