extensions/browser/updater/request_queue_impl.h - Issue 2551723002: Replace unique_ptr.reset/release with std::move under src/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/updater/request_queue_impl.h

Issue 2551723002: Replace unique_ptr.reset/release with std::move under src/extensions (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/updater/request_queue_impl.h

diff --git a/extensions/browser/updater/request_queue_impl.h b/extensions/browser/updater/request_queue_impl.h

index c8e0a8c962db3225aaa84915e4420da892688a90..5eb5148a95923399ce7182e5ac65455c3bdd9f9c 100644

--- a/extensions/browser/updater/request_queue_impl.h

+++ b/extensions/browser/updater/request_queue_impl.h

@@ -112,8 +112,8 @@ void RequestQueue<T>::StartNextRequest() {

std::pop_heap(

pending_requests_.begin(), pending_requests_.end(), CompareRequests);

- active_backoff_entry_.reset(pending_requests_.back().backoff_entry.release());

- active_request_.reset(pending_requests_.back().request.release());

+ active_backoff_entry_ = std::move(pending_requests_.back().backoff_entry);

+ active_request_ = std::move(pending_requests_.back().request);

pending_requests_.pop_back();