extensions/browser/api/networking_private/networking_private_delegate_factory.cc - Issue 2551723002: Replace unique_ptr.reset/release with std::move under src/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/networking_private/networking_private_delegate_factory.cc

Issue 2551723002: Replace unique_ptr.reset/release with std::move under src/extensions (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/networking_private/networking_private_delegate.h ('k') | extensions/browser/api/web_request/web_request_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/networking_private/networking_private_delegate_factory.cc

diff --git a/extensions/browser/api/networking_private/networking_private_delegate_factory.cc b/extensions/browser/api/networking_private/networking_private_delegate_factory.cc

index 2cee55591e6f8af641e5e348f1b254530d75e9f0..ff725301637a821bd1682787903d3bb89f2c8f97 100644

--- a/extensions/browser/api/networking_private/networking_private_delegate_factory.cc

+++ b/extensions/browser/api/networking_private/networking_private_delegate_factory.cc

@@ -59,12 +59,12 @@ NetworkingPrivateDelegateFactory::~NetworkingPrivateDelegateFactory() {

void NetworkingPrivateDelegateFactory::SetVerifyDelegateFactory(

std::unique_ptr<VerifyDelegateFactory> factory) {

- verify_factory_.reset(factory.release());

+ verify_factory_ = std::move(factory);

}

void NetworkingPrivateDelegateFactory::SetUIDelegateFactory(

std::unique_ptr<UIDelegateFactory> factory) {

- ui_factory_.reset(factory.release());

+ ui_factory_ = std::move(factory);

}

KeyedService* NetworkingPrivateDelegateFactory::BuildServiceInstanceFor(