Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2551053002: [wasm] Always provide a wasm instance object at runtime (Closed)

Created:
4 years ago by Clemens Hammacher
Modified:
4 years ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Always provide a wasm instance object at runtime When executing wasm code for testing, we did not create a WasmInstanceObject and link it to the generated code. This required some special handling at runtime (mainly for stack trace generation). This CL always provides the WasmInstanceObject, such that e.g. function names can be resolved the usual way. The module bytes referenced by the WasmCompiledModule linked with the WasmInstanceObject do not hold a valid wasm module yet. Instead, we just add the bytes we need, and make the objects in WasmModule point to those bytes (currently only used for function names). Those bytes will not be parsed at runtime anyway. R=titzer@chromium.org CC=jgruber@chromium.org BUG=v8:5620 Review-Url: https://codereview.chromium.org/2551053002 Cr-Commit-Position: refs/heads/master@{#41809} Committed: https://chromium.googlesource.com/v8/v8/+/21a85c4a03833b3fe70bfcd8ab414b42750475e9

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -160 lines) Patch
M src/frames.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M src/frames.cc View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M src/isolate.cc View 1 2 2 chunks +6 lines, -9 lines 0 comments Download
M src/messages.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 1 2 2 chunks +7 lines, -11 lines 0 comments Download
M src/vector.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/wasm/wasm-module.h View 1 2 2 chunks +0 lines, -10 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 2 8 chunks +17 lines, -93 lines 0 comments Download
M src/wasm/wasm-objects.h View 1 2 3 chunks +20 lines, -2 lines 0 comments Download
M src/wasm/wasm-objects.cc View 1 2 3 chunks +64 lines, -0 lines 0 comments Download
M test/cctest/wasm/test-wasm-stack.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M test/cctest/wasm/test-wasm-trap-position.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 1 2 12 chunks +55 lines, -12 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (15 generated)
Clemens Hammacher
4 years ago (2016-12-05 12:15:27 UTC) #9
jgruber
Awesome, thanks!
4 years ago (2016-12-05 12:22:06 UTC) #10
titzer
On 2016/12/05 12:22:06, jgruber wrote: > Awesome, thanks! lgtm
4 years ago (2016-12-19 14:39:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2551053002/40001
4 years ago (2016-12-19 15:01:39 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-19 15:03:25 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/21a85c4a03833b3fe70bfcd8ab414b42750...

Powered by Google App Engine
This is Rietveld 408576698