[wasm] Implement GetPossibleBreakpoints

[wasm] Implement GetPossibleBreakpoints

This CL implements GetPossibleBreakpoints for wasm, by iterating over
all functions in the requested range and returning the location of all
instructions within that range.

The connection to the inspector will be added later, when setting
breakpoint also works for wasm: http://crrev.com/2536763002

BUG=chromium:613110
R=titzer@chromium.org

Review-Url: https://codereview.chromium.org/2588763002
Cr-Commit-Position: refs/heads/master@{#41818}
Committed: https://chromium.googlesource.com/v8/v8/+/1fef739ab072b9262d83b50c8fec9f4b1409e099

[Clemens Hammacher, 2016-12-19 15:31:45]

The CQ bit was checked by clemensh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-19 15:31:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[titzer, 2016-12-19 15:44:58]

lgtm with nit

https://codereview.chromium.org/2588763002/diff/1/src/wasm/wasm-objects.cc
File src/wasm/wasm-objects.cc (right):

https://codereview.chromium.org/2588763002/diff/1/src/wasm/wasm-objects.cc#ne...
src/wasm/wasm-objects.cc:667: DCHECK(!functions.empty());
Isn't this check redundant with the check below? I.e. if functions.size() == 0,
then the first if below will fail.

[commit-bot: I haz the power, 2016-12-19 15:57:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-19 15:57:39]

Dry run: This issue passed the CQ dry run.

[Clemens Hammacher, 2016-12-19 15:59:22]

https://codereview.chromium.org/2588763002/diff/1/src/wasm/wasm-objects.cc
File src/wasm/wasm-objects.cc (right):

https://codereview.chromium.org/2588763002/diff/1/src/wasm/wasm-objects.cc#ne...
src/wasm/wasm-objects.cc:667: DCHECK(!functions.empty());
On 2016/12/19 at 15:44:58, titzer wrote:
> Isn't this check redundant with the check below? I.e. if functions.size() ==
0, then the first if below will fail.

True, it's not needed for the code below to work, so I will remove it.

[Clemens Hammacher, 2016-12-19 16:56:44]

The CQ bit was checked by clemensh@chromium.org

[Clemens Hammacher, 2016-12-19 16:56:45]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2588763002/#ps20001
(title: "Address comment")

[commit-bot: I haz the power, 2016-12-19 16:56:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-19 17:22:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482166604833660,
"parent_rev": "b6a57e6ff5ed7f6db3ff503e245a1f9535e968cc", "commit_rev":
"1fef739ab072b9262d83b50c8fec9f4b1409e099"}

[commit-bot: I haz the power, 2016-12-19 17:23:01]

Description was changed from

==========
[wasm] Implement GetPossibleBreakpoints

This CL implements GetPossibleBreakpoints for wasm, by iterating over
all functions in the requested range and returning the location of all
instructions within that range.

The connection to the inspector will be added later, when setting
breakpoint also works for wasm: http://crrev.com/2536763002

BUG=chromium:613110
R=titzer@chromium.org
==========

to

==========
[wasm] Implement GetPossibleBreakpoints

This CL implements GetPossibleBreakpoints for wasm, by iterating over
all functions in the requested range and returning the location of all
instructions within that range.

The connection to the inspector will be added later, when setting
breakpoint also works for wasm: http://crrev.com/2536763002

BUG=chromium:613110
R=titzer@chromium.org

Review-Url: https://codereview.chromium.org/2588763002
Cr-Commit-Position: refs/heads/master@{#41818}
Committed:
https://chromium.googlesource.com/v8/v8/+/1fef739ab072b9262d83b50c8fec9f4b140...
==========

[commit-bot: I haz the power, 2016-12-19 17:23:02]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/1fef739ab072b9262d83b50c8fec9f4b140...