Issue 255101: Mac: Find bar should be drawn on top of all other toolbars.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 255101: Mac: Find bar should be drawn on top of all other toolbars. (Closed)

Created:
11 years, 2 months ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
John Grabowski, Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Mac: Find bar should be drawn on top of all other toolbars. BUG=24000

Patch Set 1 #

Total comments: 2

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -1 line)			Patch
	M	chrome/browser/cocoa/browser_window_controller.mm	View		1 chunk	+3 lines, -1 line	1 comment	Download
	M	chrome/browser/cocoa/browser_window_controller_unittest.mm	View		3 chunks	+25 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

John Grabowski

11 years, 2 months ago (2009-10-07 04:56:50 UTC) #2

LGTM

http://codereview.chromium.org/255101/diff/1/2
File chrome/browser/cocoa/browser_window_controller.mm (right):

http://codereview.chromium.org/255101/diff/1/2#newcode205
Line 205: [[[self window] contentView] addSubview:[bookmarkBarController_ view]
Add comment explaining why (e.g. "so find bar is above...")

http://codereview.chromium.org/255101/diff/1/3
File chrome/browser/cocoa/browser_window_controller_unittest.mm (right):

http://codereview.chromium.org/255101/diff/1/3#newcode444
Line 444: TEST_F(BrowserWindowControllerTest, TestFindBarOnTop) {
jrg <3 erg

Expand Messages | Collapse Messages