Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6009)

Unified Diff: chrome/browser/cocoa/browser_window_controller.mm

Issue 255101: Mac: Find bar should be drawn on top of all other toolbars. (Closed)
Patch Set: Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/cocoa/browser_window_controller.mm b/chrome/browser/cocoa/browser_window_controller.mm
index 542d5d2b47450e3213ac77db5cad41a3271c697e..2d34da466a901c7a16f291277e4a8b20a133f4ef 100644
--- a/chrome/browser/cocoa/browser_window_controller.mm
+++ b/chrome/browser/cocoa/browser_window_controller.mm
@@ -202,7 +202,9 @@ willPositionSheet:(NSWindow*)sheet
// nib load. The bookmark bar is defined (in the nib) to be
// bottom-aligned to it's parent view (among other things), so
// position and resize properties don't need to be set.
- [[[self window] contentView] addSubview:[bookmarkBarController_ view]];
+ [[[self window] contentView] addSubview:[bookmarkBarController_ view]
John Grabowski 2009/10/07 04:56:50 Add comment explaining why (e.g. "so find bar is a
+ positioned:NSWindowBelow
+ relativeTo:[toolbarController_ view]];
// We don't want to try and show the bar before it gets placed in
// it's parent view, so this step shoudn't be inside the bookmark

Powered by Google App Engine
This is Rietveld 408576698