Mac: Find bar should be drawn on top of all other toolbars.

chrome/browser/cocoa/browser_window_controller_unittest.mm

Index: chrome/browser/cocoa/browser_window_controller_unittest.mm
diff --git a/chrome/browser/cocoa/browser_window_controller_unittest.mm b/chrome/browser/cocoa/browser_window_controller_unittest.mm
index 5df2fdd886e60033192fc8fb6c694407caf01e2e..e4ad36430adc535740adfc58669c6907c0e3dd98 100644
--- a/chrome/browser/cocoa/browser_window_controller_unittest.mm
+++ b/chrome/browser/cocoa/browser_window_controller_unittest.mm
@@ -9,6 +9,7 @@
 #include "chrome/browser/cocoa/browser_test_helper.h"
 #include "chrome/browser/cocoa/browser_window_controller.h"
 #include "chrome/browser/cocoa/cocoa_test_helper.h"
+#include "chrome/browser/cocoa/find_bar_bridge.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/pref_service.h"
 #include "chrome/test/testing_browser_process.h"
@@ -43,6 +44,10 @@
   return [bookmarkBarController_ view];
 }
 
+- (NSView*)findBarView {
+  return [findBarCocoaController_ view];
+}
+
 - (BOOL)bookmarkBarVisible {
   return [bookmarkBarController_ isVisible];
 }
@@ -436,5 +441,25 @@ TEST_F(BrowserWindowControllerTest, TestZoomFrame) {
   EXPECT_EQ(screenFrame.origin.y, zoomFrame.origin.y);
 }
 
+TEST_F(BrowserWindowControllerTest, TestFindBarOnTop) {

[John Grabowski, 2009/10/07 04:56:50]

jrg <3 erg

+  FindBarBridge bridge;
+  [controller_.get() addFindBar:bridge.find_bar_cocoa_controller()];
+
+  // Test that the Z-order of the find bar is on top of everything.
+  NSArray* subviews = [[[controller_.get() window] contentView] subviews];
+  NSUInteger findBar_index =
+      [subviews indexOfObject:[controller_.get() findBarView]];
+  EXPECT_NE(NSNotFound, findBar_index);
+  NSUInteger toolbar_index =
+      [subviews indexOfObject:[controller_.get() toolbarView]];
+  EXPECT_NE(NSNotFound, toolbar_index);
+  NSUInteger bookmark_index =
+      [subviews indexOfObject:[controller_.get() bookmarkView]];
+  EXPECT_NE(NSNotFound, bookmark_index);
+
+  EXPECT_GT(findBar_index, toolbar_index);
+  EXPECT_GT(findBar_index, bookmark_index);
+}
+
 
 /* TODO(???): test other methods of BrowserWindowController */