Mac: Find bar should be drawn on top of all other toolbars.

chrome/browser/cocoa/browser_window_controller.mm

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <Carbon/Carbon.h>
 
 #include "base/mac_util.h"
 #include "base/scoped_nsdisable_screen_updates.h"
 #import "base/scoped_nsobject.h"
 #include "base/sys_string_conversions.h"
@@ skipping 184 matching lines @@
             initWithBrowser:browser_.get()
                initialWidth:NSWidth([[[self window] contentView] frame])
            compressDelegate:toolbarController_.get()
              resizeDelegate:self
                 urlDelegate:self]);
 
     // Add bookmark bar to the view hierarchy.  This also triggers the
     // nib load.  The bookmark bar is defined (in the nib) to be
     // bottom-aligned to it's parent view (among other things), so
     // position and resize properties don't need to be set.
-    [[[self window] contentView] addSubview:[bookmarkBarController_ view]];
+    [[[self window] contentView] addSubview:[bookmarkBarController_ view]

[John Grabowski, 2009/10/07 04:56:50]

Add comment explaining why (e.g. "so find bar is above...")

+                                 positioned:NSWindowBelow
+                                 relativeTo:[toolbarController_ view]];
 
     // We don't want to try and show the bar before it gets placed in
     // it's parent view, so this step shoudn't be inside the bookmark
     // bar controller's awakeFromNib.
     [bookmarkBarController_ showIfNeeded];
 
     if (browser_->SupportsWindowFeature(Browser::FEATURE_EXTENSIONSHELF)) {
       // Create the extension shelf.
       extensionShelfController_.reset([[ExtensionShelfController alloc]
                                         initWithBrowser:browser_.get()
@@ skipping 1238 matching lines @@
       provider->GetNSColor(BrowserThemeProvider::COLOR_TOOLBAR);
   [theme setValue:toolbarBackgroundColor
      forAttribute:@"backgroundColor"
             style:GTMThemeStyleToolBar
             state:GTMThemeStateActiveWindow];
 
   return theme;
 }
 @end