DescriptionRevert of Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting (patchset #1 id:1 of https://codereview.chromium.org/2554763002/ )
Reason for revert:
Reason for revert:
A lot of css tests started failing after this CL:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/6264
Original issue's description:
> Reland of Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting (patchset #1 id:1 of https://codereview.chromium.org/2550333002/ )
>
> Reason for revert:
> The failures were because of conflict with https://codereview.chromium.org/2502353003/ which
> has been reverted.
>
> Original issue's description:
> > Revert of Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting (patchset #8 id:140001 of https://codereview.chromium.org/2549553002/ )
> >
> > Reason for revert:
> > Breaks the following webkit_unit_tests:
> > TableCellPainterTest.CollapsedBorderAndOverflow
> > TablePainterTest.CollapsedBorderInterestRectChange
> > All/PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgrounds/0
> > All/PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgrounds/2
> > All/PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgroundsDynamic/2
> > All/PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgroundsDynamic/0
> > on WebKit Win x64 Builder (dbg)
> > https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win%20x64%20Builder%20%28dbg%29/builds/99618
> >
> > Original issue's description:
> > > Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting
> > >
> > > Checks that nothing should be painted if
> > > paintedOutputOfObjectHasNoEffectRegardlessOfSize() is true, to
> > > catch under-invalidations caused by it.
> > >
> > > The verification also works during the first paint, so the existing
> > > layout tests have enough coverage for the function.
> > >
> > > Also fixed some check failures:
> > > - LayoutDetailsMarker: was actual under-invalidation.
> > > - LayoutView: as display item client of frame scroll corner. Was not an
> > > actual under-invalidation because scroll controls are invalidated
> > > separately, but change code to avoid the check failure. This is not
> > > applicable to rootLayerScrolling.
> > > - LayoutSVGBlock (LayoutSVGText and LayoutSVGForeignObject): now assume
> > > there is always SVG effects.
> > >
> > > Objects painted in SkPictureBuilder are not checked. One example is
> > > LayoutSVGResourceClipper which doesn't have any painting on the backing,
> > > but may output paint operations in SkPictureBuilder for the clipped
> > > object.
> > >
> > > BUG=669327
> > > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > >
> > > Committed: https://crrev.com/31a69618a214eb36bad90baa1a4f4d6bc15d008e
> > > Cr-Commit-Position: refs/heads/master@{#436455}
> >
> > TBR=chrishtr@chromium.org,pdr@chromium.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=669327
> >
> > Committed: https://crrev.com/f6231f793a5e42804598473806f3f43046ac1fbc
> > Cr-Commit-Position: refs/heads/master@{#436476}
>
> TBR=chrishtr@chromium.org,pdr@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=669327
>
> Committed: https://crrev.com/8f64b7c27bc9a8757977498ee748c641bfe7247e
> Cr-Commit-Position: refs/heads/master@{#436518}
TBR=chrishtr@chromium.org,pdr@chromium.org,wangxianzhu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=669327
Committed: https://crrev.com/4f26eb8a561510d386054ad75a4a77bcb515f4f2
Cr-Commit-Position: refs/heads/master@{#436542}
Patch Set 1 #Messages
Total messages: 9 (4 generated)
|