Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2550333002: Revert of Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting (Closed)

Created:
4 years ago by Xianzhu
Modified:
4 years ago
Reviewers:
chrishtr, pdr.
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting (patchset #8 id:140001 of https://codereview.chromium.org/2549553002/ ) Reason for revert: Breaks the following webkit_unit_tests: TableCellPainterTest.CollapsedBorderAndOverflow TablePainterTest.CollapsedBorderInterestRectChange All/PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgrounds/0 All/PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgrounds/2 All/PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgroundsDynamic/2 All/PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgroundsDynamic/0 on WebKit Win x64 Builder (dbg) https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win%20x64%20Builder%20%28dbg%29/builds/99618 Original issue's description: > Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting > > Checks that nothing should be painted if > paintedOutputOfObjectHasNoEffectRegardlessOfSize() is true, to > catch under-invalidations caused by it. > > The verification also works during the first paint, so the existing > layout tests have enough coverage for the function. > > Also fixed some check failures: > - LayoutDetailsMarker: was actual under-invalidation. > - LayoutView: as display item client of frame scroll corner. Was not an > actual under-invalidation because scroll controls are invalidated > separately, but change code to avoid the check failure. This is not > applicable to rootLayerScrolling. > - LayoutSVGBlock (LayoutSVGText and LayoutSVGForeignObject): now assume > there is always SVG effects. > > Objects painted in SkPictureBuilder are not checked. One example is > LayoutSVGResourceClipper which doesn't have any painting on the backing, > but may output paint operations in SkPictureBuilder for the clipped > object. > > BUG=669327 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Committed: https://crrev.com/31a69618a214eb36bad90baa1a4f4d6bc15d008e > Cr-Commit-Position: refs/heads/master@{#436455} TBR=chrishtr@chromium.org,pdr@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=669327 Committed: https://crrev.com/f6231f793a5e42804598473806f3f43046ac1fbc Cr-Commit-Position: refs/heads/master@{#436476}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -106 lines) Patch
M third_party/WebKit/LayoutTests/paint/invalidation/resize-scrollable-iframe-expected.txt View 2 chunks +0 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/resize-scrollable-iframe-expected.txt View 2 chunks +0 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/line-flow-with-floats-9-expected.txt View 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/line-flow-with-floats-9-expected.txt View 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutDetailsMarker.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGBlock.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp View 1 chunk +2 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.h View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/SkPictureBuilder.cpp View 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Xianzhu
Created Revert of Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting
4 years ago (2016-12-06 01:01:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550333002/1
4 years ago (2016-12-06 01:02:20 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 01:03:37 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f6231f793a5e42804598473806f3f43046ac1fbc Cr-Commit-Position: refs/heads/master@{#436476}
4 years ago (2016-12-06 01:08:09 UTC) #8
Xianzhu
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2554763002/ by wangxianzhu@chromium.org. ...
4 years ago (2016-12-06 03:57:27 UTC) #9
haraken
4 years ago (2016-12-06 06:58:42 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2555683002/ by haraken@chromium.org.

The reason for reverting is: A lot of css tests started failing after this CL:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28...
.

Powered by Google App Engine
This is Rietveld 408576698