Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting

Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting

Checks that nothing should be painted if
paintedOutputOfObjectHasNoEffectRegardlessOfSize() is true, to
catch under-invalidations caused by it.

The verification also works during the first paint, so the existing
layout tests have enough coverage for the function.

Also fixed some check failures:
- LayoutDetailsMarker: was actual under-invalidation.
- LayoutView: as display item client of frame scroll corner. Was not an
  actual under-invalidation because scroll controls are invalidated
  separately, but change code to avoid the check failure. This is not
  applicable to rootLayerScrolling.
- LayoutSVGBlock (LayoutSVGText and LayoutSVGForeignObject): now assume
  there is always SVG effects.

Objects painted in SkPictureBuilder are not checked. One example is
LayoutSVGResourceClipper which doesn't have any painting on the backing,
but may output paint operations in SkPictureBuilder for the clipped
object.

BUG=669327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/31a69618a214eb36bad90baa1a4f4d6bc15d008e
Cr-Commit-Position: refs/heads/master@{#436455}

[Xianzhu, 2016-12-01 17:18:58]

Description was changed from

==========
Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting

Checks that nothing should be painted if
paintedOutputOfObjectHasNoEffectRegardlessOfSize() is true, to
catch under-invalidations caused by it.

The verification also works during the first paint, so the existing
layout tests have enough coverage for the function.

BUG=669327
==========

to

==========
Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting

Checks that nothing should be painted if
paintedOutputOfObjectHasNoEffectRegardlessOfSize() is true, to
catch under-invalidations caused by it.

The verification also works during the first paint, so the existing
layout tests have enough coverage for the function.

BUG=669327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-12-01 17:19:00]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 17:19:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xianzhu, 2016-12-01 18:15:56]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 18:15:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 19:38:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 19:38:40]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xianzhu, 2016-12-01 20:43:27]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 20:44:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 21:33:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 21:33:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2016-12-02 22:44:25]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 22:45:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-03 00:42:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-03 00:42:25]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xianzhu, 2016-12-03 21:02:15]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-03 21:02:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-03 22:20:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-03 22:20:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xianzhu, 2016-12-03 22:28:28]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-03 22:28:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-03 23:48:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-03 23:48:15]

Dry run: This issue passed the CQ dry run.

[Xianzhu, 2016-12-04 02:53:28]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-04 02:53:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-04 04:24:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-04 04:24:01]

Dry run: This issue passed the CQ dry run.

[Xianzhu, 2016-12-04 05:13:29]

Description was changed from

==========
Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting

Checks that nothing should be painted if
paintedOutputOfObjectHasNoEffectRegardlessOfSize() is true, to
catch under-invalidations caused by it.

The verification also works during the first paint, so the existing
layout tests have enough coverage for the function.

BUG=669327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting

Checks that nothing should be painted if
paintedOutputOfObjectHasNoEffectRegardlessOfSize() is true, to
catch under-invalidations caused by it.

The verification also works during the first paint, so the existing
layout tests have enough coverage for the function.

Also fixed some check failures:
- LayoutDetailsMarker: was actual under-invalidation
- LayoutView: as display item client of frame scroll corner. Was not an
  actual under-invalidation because scroll controls are invalidated
  separately, but change code to avoid the check failure. This is not
  applicable to rootLayerScrolling
- LayoutSVGBlock (LayoutSVGText and LayoutSVGForeignObject): now assume
  there is always SVG effects

Objects painted in SkPictureBuilder is not checked. One example is
LayoutSVGResourceClipper which doesn't have any painting on the backing,
but may output paint operations in SkPictureBuilder for the clipped
object. 

BUG=669327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-12-04 05:13:51]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org, pdr@chromium.org

[chrishtr, 2016-12-05 21:20:28]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-12-05 21:20:28]

lgtm

[chrishtr, 2016-12-05 21:20:47]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2016-12-05 21:21:12]

https://codereview.chromium.org/2549553002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h
(right):

https://codereview.chromium.org/2549553002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h:68:
virtual bool paintedOutputOfObjectHasNoEffectRegardlessOfSize() const {
Remove this method from LayoutObject?

[Xianzhu, 2016-12-05 21:27:15]

Description was changed from

==========
Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting

Checks that nothing should be painted if
paintedOutputOfObjectHasNoEffectRegardlessOfSize() is true, to
catch under-invalidations caused by it.

The verification also works during the first paint, so the existing
layout tests have enough coverage for the function.

Also fixed some check failures:
- LayoutDetailsMarker: was actual under-invalidation
- LayoutView: as display item client of frame scroll corner. Was not an
  actual under-invalidation because scroll controls are invalidated
  separately, but change code to avoid the check failure. This is not
  applicable to rootLayerScrolling
- LayoutSVGBlock (LayoutSVGText and LayoutSVGForeignObject): now assume
  there is always SVG effects

Objects painted in SkPictureBuilder is not checked. One example is
LayoutSVGResourceClipper which doesn't have any painting on the backing,
but may output paint operations in SkPictureBuilder for the clipped
object. 

BUG=669327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting

Checks that nothing should be painted if
paintedOutputOfObjectHasNoEffectRegardlessOfSize() is true, to
catch under-invalidations caused by it.

The verification also works during the first paint, so the existing
layout tests have enough coverage for the function.

Also fixed some check failures:
- LayoutDetailsMarker: was actual under-invalidation.
- LayoutView: as display item client of frame scroll corner. Was not an
  actual under-invalidation because scroll controls are invalidated
  separately, but change code to avoid the check failure. This is not
  applicable to rootLayerScrolling.
- LayoutSVGBlock (LayoutSVGText and LayoutSVGForeignObject): now assume
  there is always SVG effects.

Objects painted in SkPictureBuilder are not checked. One example is
LayoutSVGResourceClipper which doesn't have any painting on the backing,
but may output paint operations in SkPictureBuilder for the clipped
object. 

BUG=669327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-12-05 21:29:15]

https://codereview.chromium.org/2549553002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h
(right):

https://codereview.chromium.org/2549553002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/graphics/paint/DisplayItemClient.h:68:
virtual bool paintedOutputOfObjectHasNoEffectRegardlessOfSize() const {
On 2016/12/05 21:21:12, chrishtr wrote:
> Remove this method from LayoutObject?

Done.

[Xianzhu, 2016-12-05 21:29:19]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-12-05 21:29:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2549553002/#ps140001
(title: "Remove from LayoutObject.h")

[commit-bot: I haz the power, 2016-12-05 21:29:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 23:42:54]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1480973359976160,
"parent_rev": "7144a563438fe667b4bc2cb264cb01f3fe52e7b1", "commit_rev":
"a48b1843b485e8081a1758a3cfdc73cfa1a6af29"}

[commit-bot: I haz the power, 2016-12-05 23:43:21]

Description was changed from

==========
Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting

Checks that nothing should be painted if
paintedOutputOfObjectHasNoEffectRegardlessOfSize() is true, to
catch under-invalidations caused by it.

The verification also works during the first paint, so the existing
layout tests have enough coverage for the function.

Also fixed some check failures:
- LayoutDetailsMarker: was actual under-invalidation.
- LayoutView: as display item client of frame scroll corner. Was not an
  actual under-invalidation because scroll controls are invalidated
  separately, but change code to avoid the check failure. This is not
  applicable to rootLayerScrolling.
- LayoutSVGBlock (LayoutSVGText and LayoutSVGForeignObject): now assume
  there is always SVG effects.

Objects painted in SkPictureBuilder are not checked. One example is
LayoutSVGResourceClipper which doesn't have any painting on the backing,
but may output paint operations in SkPictureBuilder for the clipped
object. 

BUG=669327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting

Checks that nothing should be painted if
paintedOutputOfObjectHasNoEffectRegardlessOfSize() is true, to
catch under-invalidations caused by it.

The verification also works during the first paint, so the existing
layout tests have enough coverage for the function.

Also fixed some check failures:
- LayoutDetailsMarker: was actual under-invalidation.
- LayoutView: as display item client of frame scroll corner. Was not an
  actual under-invalidation because scroll controls are invalidated
  separately, but change code to avoid the check failure. This is not
  applicable to rootLayerScrolling.
- LayoutSVGBlock (LayoutSVGText and LayoutSVGForeignObject): now assume
  there is always SVG effects.

Objects painted in SkPictureBuilder are not checked. One example is
LayoutSVGResourceClipper which doesn't have any painting on the backing,
but may output paint operations in SkPictureBuilder for the clipped
object. 

BUG=669327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[commit-bot: I haz the power, 2016-12-05 23:43:22]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-12-05 23:46:59]

Description was changed from

==========
Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting

Checks that nothing should be painted if
paintedOutputOfObjectHasNoEffectRegardlessOfSize() is true, to
catch under-invalidations caused by it.

The verification also works during the first paint, so the existing
layout tests have enough coverage for the function.

Also fixed some check failures:
- LayoutDetailsMarker: was actual under-invalidation.
- LayoutView: as display item client of frame scroll corner. Was not an
  actual under-invalidation because scroll controls are invalidated
  separately, but change code to avoid the check failure. This is not
  applicable to rootLayerScrolling.
- LayoutSVGBlock (LayoutSVGText and LayoutSVGForeignObject): now assume
  there is always SVG effects.

Objects painted in SkPictureBuilder are not checked. One example is
LayoutSVGResourceClipper which doesn't have any painting on the backing,
but may output paint operations in SkPictureBuilder for the clipped
object. 

BUG=669327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting

Checks that nothing should be painted if
paintedOutputOfObjectHasNoEffectRegardlessOfSize() is true, to
catch under-invalidations caused by it.

The verification also works during the first paint, so the existing
layout tests have enough coverage for the function.

Also fixed some check failures:
- LayoutDetailsMarker: was actual under-invalidation.
- LayoutView: as display item client of frame scroll corner. Was not an
  actual under-invalidation because scroll controls are invalidated
  separately, but change code to avoid the check failure. This is not
  applicable to rootLayerScrolling.
- LayoutSVGBlock (LayoutSVGText and LayoutSVGForeignObject): now assume
  there is always SVG effects.

Objects painted in SkPictureBuilder are not checked. One example is
LayoutSVGResourceClipper which doesn't have any painting on the backing,
but may output paint operations in SkPictureBuilder for the clipped
object.

BUG=669327
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/31a69618a214eb36bad90baa1a4f4d6bc15d008e
Cr-Commit-Position: refs/heads/master@{#436455}
==========

[commit-bot: I haz the power, 2016-12-05 23:47:01]

Patchset 8 (id:??) landed as
https://crrev.com/31a69618a214eb36bad90baa1a4f4d6bc15d008e
Cr-Commit-Position: refs/heads/master@{#436455}

[Xianzhu, 2016-12-06 01:01:21]

A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/2550333002/ by wangxianzhu@chromium.org.

The reason for reverting is: Breaks the following webkit_unit_tests:
TableCellPainterTest.CollapsedBorderAndOverflow
TablePainterTest.CollapsedBorderInterestRectChange
All/PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgrounds/0
All/PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgrounds/2
All/PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgroundsDynamic/2
All/PaintLayerPainterTest.TableCollapsedBorderNeedsPaintPhaseDescendantBlockBackgroundsDynamic/0
on WebKit Win x64 Builder (dbg)
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win%....

[findit-for-me, 2016-12-06 01:38:15]

FYI: Findit identified this CL at revision 436455 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...