Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 2550113003: Revert of [BlobStorage] Implementing disk. (Closed)

Created:
4 years ago by carlosk
Modified:
4 years ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [BlobStorage] Implementing disk. (patchset #18 id:340001 of https://codereview.chromium.org/2516713002/ ) Reason for revert: Seems to be breaking BlobStorageBrowserTest.BlobCombinations on "Mac10.9 Tests (dbg)". Original issue's description: > [BlobStorage] Enabling disk storage and paging. > > Adds support for saving blobs to disk by either paging them to disk > or sending files directly to the renderer. > > Note: Disk is turned off by default (limit=0). So other than tests > that explicitly set a higher disk limit, this patch should be a NOOP. > The next patch will configure this limit (and the current RAM limit) > by the OS, disk size, and available RAM. > > R=michaeln,kinuko > BUG=375297 > > Committed: https://crrev.com/89bdfe0bd9499962f9f05c30a72d46fc6510d45a > Cr-Commit-Position: refs/heads/master@{#436415} TBR=mek@chromium.org,kinuko@chromium.org,michaeln@chromium.org,pwnall@chromium.org,dmurph@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=375297 Committed: https://crrev.com/1108e1fbaf71225ba4b729185868e9e2c0e23976 Cr-Commit-Position: refs/heads/master@{#436443}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -1047 lines) Patch
M content/browser/blob_storage/blob_flattener_unittest.cc View 10 chunks +17 lines, -95 lines 0 comments Download
M content/browser/blob_storage/blob_memory_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/blob_storage/blob_slice_unittest.cc View 10 chunks +10 lines, -36 lines 0 comments Download
D content/browser/blob_storage/blob_storage_browsertest.cc View 1 chunk +0 lines, -103 lines 0 comments Download
M content/browser/blob_storage/blob_storage_context_unittest.cc View 5 chunks +4 lines, -240 lines 0 comments Download
M content/browser/blob_storage/chrome_blob_storage_context.h View 2 chunks +1 line, -4 lines 0 comments Download
M content/browser/blob_storage/chrome_blob_storage_context.cc View 5 chunks +6 lines, -65 lines 0 comments Download
M content/child/blob_storage/blob_transport_controller.cc View 3 chunks +19 lines, -24 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D content/test/data/blob_storage/blob_creation_and_slicing.html View 1 chunk +0 lines, -134 lines 0 comments Download
D content/test/data/blob_storage/common.js View 1 chunk +0 lines, -105 lines 0 comments Download
M storage/browser/blob/blob_entry.h View 5 chunks +10 lines, -17 lines 0 comments Download
M storage/browser/blob/blob_entry.cc View 1 chunk +1 line, -13 lines 0 comments Download
M storage/browser/blob/blob_memory_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/blob/blob_memory_controller.cc View 10 chunks +13 lines, -16 lines 0 comments Download
M storage/browser/blob/blob_reader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M storage/browser/blob/blob_storage_context.h View 7 chunks +8 lines, -28 lines 0 comments Download
M storage/browser/blob/blob_storage_context.cc View 15 chunks +53 lines, -156 lines 0 comments Download
M storage/common/blob_storage/blob_storage_constants.h View 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
carlosk
Created Revert of [BlobStorage] Implementing disk.
4 years ago (2016-12-05 23:16:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2550113003/1
4 years ago (2016-12-05 23:17:04 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 23:18:59 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-05 23:22:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1108e1fbaf71225ba4b729185868e9e2c0e23976
Cr-Commit-Position: refs/heads/master@{#436443}

Powered by Google App Engine
This is Rietveld 408576698