Index: storage/common/blob_storage/blob_storage_constants.h |
diff --git a/storage/common/blob_storage/blob_storage_constants.h b/storage/common/blob_storage/blob_storage_constants.h |
index b94e886f3de7bc9685442035789a2833dac6ed64..f54d20aaa701aab134152616d7699c1aea04dd93 100644 |
--- a/storage/common/blob_storage/blob_storage_constants.h |
+++ b/storage/common/blob_storage/blob_storage_constants.h |
@@ -28,8 +28,8 @@ |
size_t max_blob_in_memory_space = 500 * 1024 * 1024; |
// This is the maximum amount of disk space we can use. |
- // TODO(dmurph): Determine initial heuristic based on disk usage & arch. |
- uint64_t max_blob_disk_space = 0ull; |
+ // TODO(dmurph): Consider storage size of the device. |
+ uint64_t max_blob_disk_space = 5ull * 1024 * 1024 * 1024; |
// This is the minimum file size we can use when paging blob items to disk. |
// We combine items until we reach at least this size. |
@@ -73,13 +73,12 @@ |
// Blob state section: |
// The blob has finished. |
DONE = 200, |
- // Waiting for memory or file quota for the to-be transported data. |
+ // The system is pending on quota being granted, the transport layer |
+ // populating pending data, and/or copying data from dependent blobs. See |
+ // BlobEntry::BuildingState determine which of these are happening, as they |
+ // all can happen concurrently. |
PENDING_QUOTA = 201, |
- // Waiting for data to be transported (quota has been granted). |
PENDING_TRANSPORT = 202, |
- // Waiting for any operations involving dependent blobs after transport data |
- // has been populated. See BlobEntry::BuildingState for more info. |
- // TODO(dmurph): Change to PENDING_REFERENCED_BLOBS (crbug.com/670398). |
PENDING_INTERNALS = 203, |
LAST = PENDING_INTERNALS |
}; |