Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Unified Diff: storage/browser/blob/blob_entry.h

Issue 2550113003: Revert of [BlobStorage] Implementing disk. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/test/data/blob_storage/common.js ('k') | storage/browser/blob/blob_entry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: storage/browser/blob/blob_entry.h
diff --git a/storage/browser/blob/blob_entry.h b/storage/browser/blob/blob_entry.h
index 72d21fcb185147a7a1cbcf5078b818560278317d..3c3869e89f4d9a8b8a382c74f59dd370f590c481 100644
--- a/storage/browser/blob/blob_entry.h
+++ b/storage/browser/blob/blob_entry.h
@@ -24,15 +24,16 @@
class ShareableBlobDataItem;
class ViewBlobInternalsJob;
-// Represents a blob in BlobStorageRegistry. Exported only for unit tests.
+// This class represents a blob in BlobStorageRegistry. We export this only for
+// unit tests.
class STORAGE_EXPORT BlobEntry {
public:
using TransportAllowedCallback =
base::Callback<void(BlobStatus,
std::vector<BlobMemoryController::FileCreationInfo>)>;
- // Records a copy from a referenced blob. Copies happen after referenced blobs
- // are complete & quota for the copies is granted.
+ // This records a copy from a referenced blob. When we finish building our
+ // blob we perform all of these copies.
struct STORAGE_EXPORT ItemCopyEntry {
ItemCopyEntry(scoped_refptr<ShareableBlobDataItem> source_item,
size_t source_item_offset,
@@ -49,11 +50,11 @@
DISALLOW_COPY_AND_ASSIGN(ItemCopyEntry);
};
- // Building state for pending blobs. State can include:
- // 1. Waiting for quota to be granted for transport data (PENDING_QUOTA)
+ // This keeps track of our building state for our blob. While building, four
+ // things can be happening mostly simultaneously:
+ // 1. Waiting for quota to be reserved for memory needed (PENDING_QUOTA)
// 2. Waiting for user population of data after quota (PENDING_TRANSPORT)
- // 3. Waiting for blobs we reference to complete & quota granted for possible
- // copies. (PENDING_INTERNALS)
+ // 3. Waiting for blobs we reference to complete (PENDING_INTERNALS)
struct STORAGE_EXPORT BuildingState {
// |transport_allowed_callback| is not null when data needs population. See
// BlobStorageContext::BuildBlob for when the callback is called.
@@ -61,9 +62,6 @@
TransportAllowedCallback transport_allowed_callback,
size_t num_building_dependent_blobs);
~BuildingState();
-
- // Cancels pending memory or file requests.
- void CancelRequests();
const bool transport_items_present;
// We can have trasnport data that's either populated or unpopulated. If we
@@ -77,10 +75,7 @@
size_t num_building_dependent_blobs;
base::WeakPtr<BlobMemoryController::QuotaAllocationTask>
- transport_quota_request;
-
- // Copy quota is always memory.
- base::WeakPtr<BlobMemoryController::QuotaAllocationTask> copy_quota_request;
+ memory_quota_request;
// These are copies from a referenced blob item to our blob items. Some of
// these entries may have changed from bytes to files if they were paged.
@@ -102,9 +97,7 @@
// Returns if we're a pending blob that can finish building.
bool CanFinishBuilding() const {
- // PENDING_INTERNALS means transport is finished.
- return status_ == BlobStatus::PENDING_INTERNALS && building_state_ &&
- !building_state_->copy_quota_request &&
+ return status_ == BlobStatus::PENDING_INTERNALS &&
building_state_->num_building_dependent_blobs == 0;
}
« no previous file with comments | « content/test/data/blob_storage/common.js ('k') | storage/browser/blob/blob_entry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698