mash: Reverse the responsibilities of the NewWindowClient.

mash: Reverse the responsibilities of the NewWindowClient.

ash now has a NewWindowController which chrome connects to and hands a
NewWindowClient, instead of ash connecting to chrome to access its
NewWindowClient.

BUG=670805
TBR=elijahtaylor@chromium.org

Committed: https://crrev.com/609759b085649f1aa62bb211bba6ad0255f3ce1d
Cr-Commit-Position: refs/heads/master@{#437011}

[Elliot Glaysher, 2016-12-02 22:52:52]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 22:53:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-03 00:37:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-03 00:37:40]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Elliot Glaysher, 2016-12-06 21:09:28]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 21:10:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 22:24:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 22:24:11]

Dry run: This issue passed the CQ dry run.

[Elliot Glaysher, 2016-12-06 22:38:50]

Description was changed from

==========
mash: Reverse the responsibilities of the NewWindowClient.

ash now has a NewWindowController which chrome connects to and hands a
NewWindowClient, instead of ash connecting to chrome to access its
NewWindowClient.

[xxx: remove json stuff; this is only for testing at this point.]

BUG=
==========

to

==========
mash: Reverse the responsibilities of the NewWindowClient.

ash now has a NewWindowController which chrome connects to and hands a
NewWindowClient, instead of ash connecting to chrome to access its
NewWindowClient.

BUG=670805
==========

[Elliot Glaysher, 2016-12-06 22:38:50]

erg@chromium.org changed reviewers:
+ jamescook@chromium.org

[James Cook, 2016-12-06 22:55:42]

LGTM with nits. Thanks for fixing this.

https://codereview.chromium.org/2549903002/diff/20001/ash/common/new_window_c...
File ash/common/new_window_controller.cc (right):

https://codereview.chromium.org/2549903002/diff/20001/ash/common/new_window_c...
ash/common/new_window_controller.cc:7: #include "base/logging.h"
still needed?

https://codereview.chromium.org/2549903002/diff/20001/ash/common/new_window_c...
ash/common/new_window_controller.cc:8: #include
"content/public/common/service_names.mojom.h"
still needed?

https://codereview.chromium.org/2549903002/diff/20001/ash/common/new_window_c...
ash/common/new_window_controller.cc:9: #include
"services/service_manager/public/cpp/connector.h"
ditto

https://codereview.chromium.org/2549903002/diff/20001/ash/common/new_window_c...
ash/common/new_window_controller.cc:19: bindings_.AddBinding(this,
std::move(request));
#include <utility>

[James Cook, 2016-12-06 22:57:29]

https://codereview.chromium.org/2549903002/diff/20001/chrome/browser/ui/ash/c...
File chrome/browser/ui/ash/chrome_new_window_client.cc (right):

https://codereview.chromium.org/2549903002/diff/20001/chrome/browser/ui/ash/c...
chrome/browser/ui/ash/chrome_new_window_client.cc:53:
connector->ConnectToInterface("ash", &new_window_controller_);
FYI - I just landed a patch that provides an ash_util::GetAshServiceName() that
allows this boilerplate to be collapsed to

connect->ConnectToInterface(ash_util::GetAshServiceName(), ...)

You're welcome to use it (or not) as you like.

[Elliot Glaysher, 2016-12-06 23:28:08]

The CQ bit was checked by erg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 23:28:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 23:39:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 23:39:55]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Elliot Glaysher, 2016-12-07 00:21:25]

Description was changed from

==========
mash: Reverse the responsibilities of the NewWindowClient.

ash now has a NewWindowController which chrome connects to and hands a
NewWindowClient, instead of ash connecting to chrome to access its
NewWindowClient.

BUG=670805
==========

to

==========
mash: Reverse the responsibilities of the NewWindowClient.

ash now has a NewWindowController which chrome connects to and hands a
NewWindowClient, instead of ash connecting to chrome to access its
NewWindowClient.

BUG=670805
TBR=elijahtaylor@chromium.org
==========

[Elliot Glaysher, 2016-12-07 00:21:25]

erg@chromium.org changed reviewers:
+ sky@chromium.org, tsepez@chromium.org

[Elliot Glaysher, 2016-12-07 00:22:29]

erg@chromium.org changed reviewers:
+ elijahtaylor@chromium.org

[Elliot Glaysher, 2016-12-07 00:22:30]

sky: owners review
tsepez: mojom
elijahtaylor: fyi tbr; trivial change of a name from the ash interface

https://codereview.chromium.org/2549903002/diff/20001/ash/common/new_window_c...
File ash/common/new_window_controller.cc (right):

https://codereview.chromium.org/2549903002/diff/20001/ash/common/new_window_c...
ash/common/new_window_controller.cc:7: #include "base/logging.h"
On 2016/12/06 22:55:42, James Cook wrote:
> still needed?

Done.

https://codereview.chromium.org/2549903002/diff/20001/ash/common/new_window_c...
ash/common/new_window_controller.cc:8: #include
"content/public/common/service_names.mojom.h"
On 2016/12/06 22:55:42, James Cook wrote:
> still needed?

Done.

https://codereview.chromium.org/2549903002/diff/20001/ash/common/new_window_c...
ash/common/new_window_controller.cc:9: #include
"services/service_manager/public/cpp/connector.h"
On 2016/12/06 22:55:42, James Cook wrote:
> ditto

Done.

https://codereview.chromium.org/2549903002/diff/20001/ash/common/new_window_c...
ash/common/new_window_controller.cc:19: bindings_.AddBinding(this,
std::move(request));
On 2016/12/06 22:55:42, James Cook wrote:
> #include <utility>

Done.

https://codereview.chromium.org/2549903002/diff/20001/chrome/browser/ui/ash/c...
File chrome/browser/ui/ash/chrome_new_window_client.cc (right):

https://codereview.chromium.org/2549903002/diff/20001/chrome/browser/ui/ash/c...
chrome/browser/ui/ash/chrome_new_window_client.cc:53:
connector->ConnectToInterface("ash", &new_window_controller_);
On 2016/12/06 22:57:29, James Cook wrote:
> FYI - I just landed a patch that provides an ash_util::GetAshServiceName()
that
> allows this boilerplate to be collapsed to
> 
> connect->ConnectToInterface(ash_util::GetAshServiceName(), ...)
> 
> You're welcome to use it (or not) as you like.

Done.

[Tom Sepez, 2016-12-07 01:00:19]

lgtm

[sky, 2016-12-07 05:19:17]

LGTM

[Elliot Glaysher, 2016-12-07 18:21:14]

The CQ bit was checked by erg@chromium.org

[Elliot Glaysher, 2016-12-07 18:21:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2549903002/#ps40001
(title: "jamescook comments")

[commit-bot: I haz the power, 2016-12-07 18:21:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 18:26:52]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481134874432200,
"parent_rev": "6f2ba3f721ccd817ed37064ae82275c3bbd5b0e2", "commit_rev":
"08c713d5053bb5d425f89103149c926bbd2a6857"}

[commit-bot: I haz the power, 2016-12-07 18:27:22]

Description was changed from

==========
mash: Reverse the responsibilities of the NewWindowClient.

ash now has a NewWindowController which chrome connects to and hands a
NewWindowClient, instead of ash connecting to chrome to access its
NewWindowClient.

BUG=670805
TBR=elijahtaylor@chromium.org
==========

to

==========
mash: Reverse the responsibilities of the NewWindowClient.

ash now has a NewWindowController which chrome connects to and hands a
NewWindowClient, instead of ash connecting to chrome to access its
NewWindowClient.

BUG=670805
TBR=elijahtaylor@chromium.org
==========

[commit-bot: I haz the power, 2016-12-07 18:27:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-07 18:28:55]

Description was changed from

==========
mash: Reverse the responsibilities of the NewWindowClient.

ash now has a NewWindowController which chrome connects to and hands a
NewWindowClient, instead of ash connecting to chrome to access its
NewWindowClient.

BUG=670805
TBR=elijahtaylor@chromium.org
==========

to

==========
mash: Reverse the responsibilities of the NewWindowClient.

ash now has a NewWindowController which chrome connects to and hands a
NewWindowClient, instead of ash connecting to chrome to access its
NewWindowClient.

BUG=670805
TBR=elijahtaylor@chromium.org

Committed: https://crrev.com/609759b085649f1aa62bb211bba6ad0255f3ce1d
Cr-Commit-Position: refs/heads/master@{#437011}
==========

[commit-bot: I haz the power, 2016-12-07 18:28:57]

Patchset 3 (id:??) landed as
https://crrev.com/609759b085649f1aa62bb211bba6ad0255f3ce1d
Cr-Commit-Position: refs/heads/master@{#437011}