Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3376)

Unified Diff: chrome/browser/chromeos/chrome_interface_factory.cc

Issue 2549903002: mash: Reverse the responsibilities of the NewWindowClient. (Closed)
Patch Set: jamescook comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/chrome_interface_factory.cc
diff --git a/chrome/browser/chromeos/chrome_interface_factory.cc b/chrome/browser/chromeos/chrome_interface_factory.cc
index 939e97c15056b7c96c0dcca8f67c907e64302878..0af94b12a6806f6f28170d0c54d5703c5237c85d 100644
--- a/chrome/browser/chromeos/chrome_interface_factory.cc
+++ b/chrome/browser/chromeos/chrome_interface_factory.cc
@@ -8,7 +8,6 @@
#include <utility>
#include "ash/common/mojo_interface_factory.h"
-#include "ash/public/interfaces/new_window.mojom.h"
#include "ash/public/interfaces/shutdown.mojom.h"
#include "base/lazy_instance.h"
#include "base/memory/ptr_util.h"
@@ -20,7 +19,6 @@
#include "chrome/browser/profiles/profile_manager.h"
#include "chrome/browser/ui/ash/app_list/app_list_presenter_service.h"
#include "chrome/browser/ui/ash/ash_util.h"
-#include "chrome/browser/ui/ash/chrome_new_window_client.h"
#include "chrome/browser/ui/ash/keyboard_ui_service.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_finder.h"
@@ -116,13 +114,6 @@ class FactoryImpl {
launchable_->ProcessRequest(std::move(request));
}
- void BindRequest(ash::mojom::NewWindowClientRequest request) {
- if (!new_window_client_)
- new_window_client_.reset(new ChromeNewWindowClient);
- new_window_client_bindings_.AddBinding(new_window_client_.get(),
- std::move(request));
- }
-
void BindRequest(ash::mojom::WallpaperManagerRequest request) {
WallpaperManager::Get()->BindRequest(std::move(request));
}
@@ -139,8 +130,6 @@ class FactoryImpl {
std::unique_ptr<KeyboardUIService> keyboard_ui_service_;
mojo::BindingSet<keyboard::mojom::Keyboard> keyboard_bindings_;
std::unique_ptr<ChromeLaunchable> launchable_;
- std::unique_ptr<ChromeNewWindowClient> new_window_client_;
- mojo::BindingSet<ash::mojom::NewWindowClient> new_window_client_bindings_;
std::unique_ptr<AppListPresenterService> app_list_presenter_service_;
mojo::BindingSet<app_list::mojom::AppListPresenter>
app_list_presenter_bindings_;
@@ -169,8 +158,6 @@ bool ChromeInterfaceFactory::OnConnect(
main_thread_task_runner_);
FactoryImpl::AddFactory<mash::mojom::Launchable>(registry,
main_thread_task_runner_);
- FactoryImpl::AddFactory<ash::mojom::NewWindowClient>(
- registry, main_thread_task_runner_);
FactoryImpl::AddFactory<ash::mojom::WallpaperManager>(
registry, main_thread_task_runner_);
FactoryImpl::AddFactory<app_list::mojom::AppListPresenter>(
« no previous file with comments | « chrome/browser/chromeos/accessibility/sticky_keys_browsertest.cc ('k') | chrome/browser/ui/ash/chrome_new_window_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698