Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: ash/common/new_window_client_proxy.h

Issue 2549903002: mash: Reverse the responsibilities of the NewWindowClient. (Closed)
Patch Set: jamescook comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/common/mojo_interface_factory.cc ('k') | ash/common/new_window_client_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/new_window_client_proxy.h
diff --git a/ash/common/new_window_client_proxy.h b/ash/common/new_window_client_proxy.h
deleted file mode 100644
index fcefe0c2f6c266fd6d675327edf6a94513027eab..0000000000000000000000000000000000000000
--- a/ash/common/new_window_client_proxy.h
+++ /dev/null
@@ -1,50 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef ASH_COMMON_NEW_WINDOW_CLIENT_PROXY_H_
-#define ASH_COMMON_NEW_WINDOW_CLIENT_PROXY_H_
-
-#include "ash/public/interfaces/new_window.mojom.h"
-#include "base/macros.h"
-
-namespace service_manager {
-class Connector;
-}
-
-namespace ash {
-
-// A NewWindowClient which lazily connects to an exported mojom::NewWindowClient
-// in "content_browser" on first use.
-class NewWindowClientProxy : public mojom::NewWindowClient {
- public:
- explicit NewWindowClientProxy(service_manager::Connector* connector);
- ~NewWindowClientProxy() override;
-
- // NewWindowClient:
- void NewTab() override;
- void NewWindow(bool incognito) override;
- void OpenFileManager() override;
- void OpenCrosh() override;
- void OpenGetHelp() override;
- void RestoreTab() override;
- void ShowKeyboardOverlay() override;
- void ShowTaskManager() override;
- void OpenFeedbackPage() override;
-
- private:
- // Ensures that we have a valid |client_| before we try to use it.
- void EnsureInterface();
-
- // Clears |client_| when |client_| has a connection error.
- void OnClientConnectionError();
-
- service_manager::Connector* connector_;
- mojom::NewWindowClientPtr client_;
-
- DISALLOW_COPY_AND_ASSIGN(NewWindowClientProxy);
-};
-
-} // namespace ash
-
-#endif // ASH_COMMON_NEW_WINDOW_CLIENT_PROXY_H_
« no previous file with comments | « ash/common/mojo_interface_factory.cc ('k') | ash/common/new_window_client_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698