Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Unified Diff: chrome/browser/ui/ash/chrome_new_window_client_browsertest.cc

Issue 2549903002: mash: Reverse the responsibilities of the NewWindowClient. (Closed)
Patch Set: jamescook comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/chrome_new_window_client_browsertest.cc
diff --git a/chrome/browser/ui/ash/chrome_new_window_client_browsertest.cc b/chrome/browser/ui/ash/chrome_new_window_client_browsertest.cc
index 7ce6374fe79d72526ccc7cb8adc45fd215f30ef5..dbc2194675addd4cb3e31dc9e1c2320d75a4444b 100644
--- a/chrome/browser/ui/ash/chrome_new_window_client_browsertest.cc
+++ b/chrome/browser/ui/ash/chrome_new_window_client_browsertest.cc
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "ash/common/new_window_controller.h"
#include "ash/common/wm_shell.h"
-#include "ash/public/interfaces/new_window.mojom.h"
#include "ash/wm/window_util.h"
#include "chrome/browser/profiles/profile_manager.h"
#include "chrome/browser/ui/browser_finder.h"
@@ -33,7 +33,7 @@ IN_PROC_BROWSER_TEST_F(ChromeNewWindowClientBrowserTest,
Profile* profile1 = ProfileManager::GetActiveUserProfile();
Browser* browser1 = CreateBrowser(profile1);
// The newly created window should be created for the current active profile.
- ash::WmShell::Get()->new_window_client()->NewWindow(false);
+ ash::WmShell::Get()->new_window_controller()->NewWindow(false);
EXPECT_EQ(
chrome::FindBrowserWithWindow(ash::wm::GetActiveWindow())->profile(),
profile1);
@@ -47,7 +47,7 @@ IN_PROC_BROWSER_TEST_F(ChromeNewWindowClientBrowserTest,
Browser* browser2 = CreateBrowser(profile2);
// The newly created window should be created for the current active window's
// profile, which is |profile2|.
- ash::WmShell::Get()->new_window_client()->NewWindow(false);
+ ash::WmShell::Get()->new_window_controller()->NewWindow(false);
EXPECT_EQ(
chrome::FindBrowserWithWindow(ash::wm::GetActiveWindow())->profile(),
profile2);
@@ -55,7 +55,7 @@ IN_PROC_BROWSER_TEST_F(ChromeNewWindowClientBrowserTest,
// After activating |browser1|, the newly created window should be created
// against |browser1|'s profile.
browser1->window()->Show();
- ash::WmShell::Get()->new_window_client()->NewWindow(false);
+ ash::WmShell::Get()->new_window_controller()->NewWindow(false);
EXPECT_EQ(
chrome::FindBrowserWithWindow(ash::wm::GetActiveWindow())->profile(),
profile1);
@@ -64,7 +64,7 @@ IN_PROC_BROWSER_TEST_F(ChromeNewWindowClientBrowserTest,
// The newly created incoginito window should be created against the current
// active |browser1|'s profile.
browser1->window()->Show();
- ash::WmShell::Get()->new_window_client()->NewWindow(true);
+ ash::WmShell::Get()->new_window_controller()->NewWindow(true);
EXPECT_EQ(chrome::FindBrowserWithWindow(ash::wm::GetActiveWindow())
->profile()
->GetOriginalProfile(),
@@ -73,7 +73,7 @@ IN_PROC_BROWSER_TEST_F(ChromeNewWindowClientBrowserTest,
// The newly created incoginito window should be created against the current
// active |browser2|'s profile.
browser2->window()->Show();
- ash::WmShell::Get()->new_window_client()->NewWindow(true);
+ ash::WmShell::Get()->new_window_controller()->NewWindow(true);
EXPECT_EQ(chrome::FindBrowserWithWindow(ash::wm::GetActiveWindow())
->profile()
->GetOriginalProfile(),
« no previous file with comments | « chrome/browser/ui/ash/chrome_new_window_client.cc ('k') | chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698