Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2549563002: Only communicate CSSPrimitiveValue references from SVGLength (Closed)

Created:
4 years ago by fs
Modified:
4 years ago
Reviewers:
Stephen Chennney, pdr.
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only communicate CSSPrimitiveValue references from SVGLength Make asCSSPrimitiveValue() return a reference to a CSSPrimitiveValue, rather than a pointer. The CSSPrimitiveValue contained in the SVGLength can/should never be null. Add a helper to SVGAnimatedLength to cut down on some boilerplate for accessing the current CSSValue. Committed: https://crrev.com/2c52d7de8460af29a7f25bb48f59bcf8fb10a93a Cr-Commit-Position: refs/heads/master@{#435688}

Patch Set 1 #

Messages

Total messages: 13 (8 generated)
fs
4 years ago (2016-12-01 19:34:55 UTC) #6
Stephen Chennney
LGTM
4 years ago (2016-12-01 19:41:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2549563002/1
4 years ago (2016-12-01 20:05:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 20:11:36 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-01 20:13:45 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c52d7de8460af29a7f25bb48f59bcf8fb10a93a
Cr-Commit-Position: refs/heads/master@{#435688}

Powered by Google App Engine
This is Rietveld 408576698