third_party/WebKit/Source/core/svg/SVGLength.cpp - Issue 2549563002: Only communicate CSSPrimitiveValue references from SVGLength

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGLength.cpp

Issue 2549563002: Only communicate CSSPrimitiveValue references from SVGLength (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGLength.cpp

diff --git a/third_party/WebKit/Source/core/svg/SVGLength.cpp b/third_party/WebKit/Source/core/svg/SVGLength.cpp

index 0a2b699aca7f04b97bf6ae767f3f2483113f373c..91b9d283c38c2fbb1dba07cb7b8f6289d2926165 100644

--- a/third_party/WebKit/Source/core/svg/SVGLength.cpp

+++ b/third_party/WebKit/Source/core/svg/SVGLength.cpp

@@ -67,7 +67,7 @@ bool SVGLength::operator==(const SVGLength& other) const {

float SVGLength::value(const SVGLengthContext& context) const {

if (isCalculated())

- return context.resolveValue(*asCSSPrimitiveValue(), unitMode());

+ return context.resolveValue(asCSSPrimitiveValue(), unitMode());

return context.convertValueToUserUnits(m_value->getFloatValue(), unitMode(),

m_value->typeWithCalcResolved());