Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: third_party/WebKit/Source/core/svg/SVGEllipseElement.cpp

Issue 2549563002: Only communicate CSSPrimitiveValue references from SVGLength (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/svg/SVGEllipseElement.cpp
diff --git a/third_party/WebKit/Source/core/svg/SVGEllipseElement.cpp b/third_party/WebKit/Source/core/svg/SVGEllipseElement.cpp
index c2161df28c56c5ea2e518d02038012fab2f1bbd0..74210584eccab649d3ae5be36241c34d8fcdf7c0 100644
--- a/third_party/WebKit/Source/core/svg/SVGEllipseElement.cpp
+++ b/third_party/WebKit/Source/core/svg/SVGEllipseElement.cpp
@@ -95,21 +95,22 @@ void SVGEllipseElement::collectStyleForPresentationAttribute(
const AtomicString& value,
MutableStylePropertySet* style) {
SVGAnimatedPropertyBase* property = propertyFromAttribute(name);
- if (property == m_cx)
- addPropertyToPresentationAttributeStyle(
- style, CSSPropertyCx, m_cx->currentValue()->asCSSPrimitiveValue());
- else if (property == m_cy)
- addPropertyToPresentationAttributeStyle(
- style, CSSPropertyCy, m_cy->currentValue()->asCSSPrimitiveValue());
- else if (property == m_rx)
- addPropertyToPresentationAttributeStyle(
- style, CSSPropertyRx, m_rx->currentValue()->asCSSPrimitiveValue());
- else if (property == m_ry)
- addPropertyToPresentationAttributeStyle(
- style, CSSPropertyRy, m_ry->currentValue()->asCSSPrimitiveValue());
- else
+ if (property == m_cx) {
+ addPropertyToPresentationAttributeStyle(style, CSSPropertyCx,
+ m_cx->cssValue());
+ } else if (property == m_cy) {
+ addPropertyToPresentationAttributeStyle(style, CSSPropertyCy,
+ m_cy->cssValue());
+ } else if (property == m_rx) {
+ addPropertyToPresentationAttributeStyle(style, CSSPropertyRx,
+ m_rx->cssValue());
+ } else if (property == m_ry) {
+ addPropertyToPresentationAttributeStyle(style, CSSPropertyRy,
+ m_ry->cssValue());
+ } else {
SVGGeometryElement::collectStyleForPresentationAttribute(name, value,
style);
+ }
}
void SVGEllipseElement::svgAttributeChanged(const QualifiedName& attrName) {

Powered by Google App Engine
This is Rietveld 408576698