third_party/WebKit/Source/core/svg/SVGLength.h - Issue 2549563002: Only communicate CSSPrimitiveValue references from SVGLength

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/SVGLength.h

Issue 2549563002: Only communicate CSSPrimitiveValue references from SVGLength (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/svg/SVGLength.h

diff --git a/third_party/WebKit/Source/core/svg/SVGLength.h b/third_party/WebKit/Source/core/svg/SVGLength.h

index 1d6db092599894cec8ef477861d93111553565a4..6b04d8dca7c9e1498deb8f44baf81dfb2fb174ea 100644

--- a/third_party/WebKit/Source/core/svg/SVGLength.h

+++ b/third_party/WebKit/Source/core/svg/SVGLength.h

@@ -66,7 +66,7 @@ class SVGLength final : public SVGPropertyBase {

m_value = CSSPrimitiveValue::create(value, m_value->typeWithCalcResolved());

}

- const CSSPrimitiveValue* asCSSPrimitiveValue() const { return m_value.get(); }

+ const CSSPrimitiveValue& asCSSPrimitiveValue() const { return *m_value; }

// Resolves LengthTypePercentage into a normalized floating point number (full

// value is 1.0).