Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/paint/SkPictureBuilder.cpp

Issue 2549553002: Verify paintedOutputOfObjectHasNoEffectRegardlessOfSize during painting (Closed)
Patch Set: Remove from LayoutObject.h Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/graphics/paint/PaintController.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/graphics/paint/SkPictureBuilder.h" 5 #include "platform/graphics/paint/SkPictureBuilder.h"
6 6
7 #include "platform/geometry/FloatRect.h" 7 #include "platform/geometry/FloatRect.h"
8 #include "platform/graphics/GraphicsContext.h" 8 #include "platform/graphics/GraphicsContext.h"
9 #include "platform/graphics/paint/PaintController.h" 9 #include "platform/graphics/paint/PaintController.h"
10 #include "wtf/PtrUtil.h" 10 #include "wtf/PtrUtil.h"
11 11
12 namespace blink { 12 namespace blink {
13 13
14 SkPictureBuilder::SkPictureBuilder(const FloatRect& bounds, 14 SkPictureBuilder::SkPictureBuilder(const FloatRect& bounds,
15 SkMetaData* metaData, 15 SkMetaData* metaData,
16 GraphicsContext* containingContext, 16 GraphicsContext* containingContext,
17 PaintController* paintController) 17 PaintController* paintController)
18 : m_paintController(nullptr), m_bounds(bounds) { 18 : m_paintController(nullptr), m_bounds(bounds) {
19 GraphicsContext::DisabledMode disabledMode = GraphicsContext::NothingDisabled; 19 GraphicsContext::DisabledMode disabledMode = GraphicsContext::NothingDisabled;
20 if (containingContext && containingContext->contextDisabled()) 20 if (containingContext && containingContext->contextDisabled())
21 disabledMode = GraphicsContext::FullyDisabled; 21 disabledMode = GraphicsContext::FullyDisabled;
22 22
23 if (paintController) { 23 if (paintController) {
24 m_paintController = paintController; 24 m_paintController = paintController;
25 } else { 25 } else {
26 m_paintControllerPtr = PaintController::create(); 26 m_paintControllerPtr = PaintController::create();
27 m_paintController = m_paintControllerPtr.get(); 27 m_paintController = m_paintControllerPtr.get();
28 } 28 }
29 #if DCHECK_IS_ON()
30 m_paintController->setUsage(PaintController::ForSkPictureBuilder);
31 #endif
32
29 m_context = wrapUnique( 33 m_context = wrapUnique(
30 new GraphicsContext(*m_paintController, disabledMode, metaData)); 34 new GraphicsContext(*m_paintController, disabledMode, metaData));
31 35
32 if (containingContext) { 36 if (containingContext) {
33 m_context->setDeviceScaleFactor(containingContext->deviceScaleFactor()); 37 m_context->setDeviceScaleFactor(containingContext->deviceScaleFactor());
34 m_context->setPrinting(containingContext->printing()); 38 m_context->setPrinting(containingContext->printing());
35 } 39 }
36 } 40 }
37 41
38 SkPictureBuilder::~SkPictureBuilder() {} 42 SkPictureBuilder::~SkPictureBuilder() {
43 #if DCHECK_IS_ON()
44 m_paintController->setUsage(PaintController::ForNormalUsage);
45 #endif
46 }
39 47
40 sk_sp<SkPicture> SkPictureBuilder::endRecording() { 48 sk_sp<SkPicture> SkPictureBuilder::endRecording() {
41 m_context->beginRecording(m_bounds); 49 m_context->beginRecording(m_bounds);
42 m_paintController->commitNewDisplayItems(); 50 m_paintController->commitNewDisplayItems();
43 m_paintController->paintArtifact().replay(*m_context); 51 m_paintController->paintArtifact().replay(*m_context);
44 return m_context->endRecording(); 52 return m_context->endRecording();
45 } 53 }
46 54
47 } // namespace blink 55 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/graphics/paint/PaintController.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698