Common GrGLInterface OpenGL setup function.

Move GrGLInterface function ptr setup into a common function for all OpenGL GrGLInterface factories (but not GLES yet).

Committed: http://code.google.com/p/skia/source/detail?r=14444

[robertphillips, 2014-04-29 15:22:53]

Yay - way less code duplication!

lgtm modulo questions.

https://codereview.chromium.org/254713006/diff/110001/src/gpu/gl/GrGLAssemble...
File src/gpu/gl/GrGLAssembleInterface.cpp (right):

https://codereview.chromium.org/254713006/diff/110001/src/gpu/gl/GrGLAssemble...
src/gpu/gl/GrGLAssembleInterface.cpp:16: const GrGLInterface*
GrGLAssembleGLInterface(void* ctx, GrGLGetProc get) {
What do you think about having a GET_PROC_LOCAL macro for getString, getIntegerv
and getStringi?

https://codereview.chromium.org/254713006/diff/110001/src/gpu/gl/GrGLAssemble...
src/gpu/gl/GrGLAssembleInterface.cpp:48: GET_PROC(BindBuffer);
The Mac version had this guard here: if (ver >= GR_GL_VER(3,0)) {

https://codereview.chromium.org/254713006/diff/110001/src/gpu/gl/android/GrGL...
File src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp (right):

https://codereview.chromium.org/254713006/diff/110001/src/gpu/gl/android/GrGL...
src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp:236: 
mv "interface" into ES block?

https://codereview.chromium.org/254713006/diff/110001/src/gpu/gl/win/GrGLCrea...
File src/gpu/gl/win/GrGLCreateNativeInterface_win.cpp (right):

https://codereview.chromium.org/254713006/diff/110001/src/gpu/gl/win/GrGLCrea...
src/gpu/gl/win/GrGLCreateNativeInterface_win.cpp:31: public:
We did lose the guard if the load fails: NULL == alu.get()

[bsalomon, 2014-04-29 19:25:55]

https://codereview.chromium.org/254713006/diff/110001/src/gpu/gl/GrGLAssemble...
File src/gpu/gl/GrGLAssembleInterface.cpp (right):

https://codereview.chromium.org/254713006/diff/110001/src/gpu/gl/GrGLAssemble...
src/gpu/gl/GrGLAssembleInterface.cpp:16: const GrGLInterface*
GrGLAssembleGLInterface(void* ctx, GrGLGetProc get) {
On 2014/04/29 15:22:54, robertphillips wrote:
> What do you think about having a GET_PROC_LOCAL macro for getString,
getIntegerv
> and getStringi?

Done.

https://codereview.chromium.org/254713006/diff/110001/src/gpu/gl/GrGLAssemble...
src/gpu/gl/GrGLAssembleInterface.cpp:48: GET_PROC(BindBuffer);
On 2014/04/29 15:22:54, robertphillips wrote:
> The Mac version had this guard here: if (ver >= GR_GL_VER(3,0)) {

Done.

https://codereview.chromium.org/254713006/diff/110001/src/gpu/gl/android/GrGL...
File src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp (right):

https://codereview.chromium.org/254713006/diff/110001/src/gpu/gl/android/GrGL...
src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp:236: 
On 2014/04/29 15:22:54, robertphillips wrote:
> mv "interface" into ES block?

Done.

https://codereview.chromium.org/254713006/diff/110001/src/gpu/gl/win/GrGLCrea...
File src/gpu/gl/win/GrGLCreateNativeInterface_win.cpp (right):

https://codereview.chromium.org/254713006/diff/110001/src/gpu/gl/win/GrGLCrea...
src/gpu/gl/win/GrGLCreateNativeInterface_win.cpp:31: public:
On 2014/04/29 15:22:54, robertphillips wrote:
> We did lose the guard if the load fails: NULL == alu.get()

Done.

[bsalomon, 2014-04-29 19:26:00]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-04-29 19:26:56]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/bsalomon@google.com/254713006/150001

[commit-bot: I haz the power, 2014-04-29 19:32:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-29 19:32:34]

Retried try job too often on Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot for
step(s) BuildBench, BuildEverything, BuildGm, BuildSkiaLib, BuildTests,
BuildTools
http://skia-tree-status.appspot.com/redirect/compile-buildbots/buildstatus?bu...

[bsalomon, 2014-04-29 19:42:23]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-04-29 19:42:59]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/bsalomon@google.com/254713006/150001

[commit-bot: I haz the power, 2014-04-29 20:06:48]

Change committed as 14444

[epoger, 2014-04-29 21:44:08]

Do you think this CL might be responsible for the following two buildbot breaks?
 It's the only CL in both blamelists, aside from Hal's Android-specific CL...

http://108.170.220.120:10117/builders/Perf-Win8-ShuttleA-GTX660-x86-Release/b...

http://108.170.220.120:10117/builders/Perf-Win7-ShuttleA-HD2000-x86-Release-D...

[epoger, 2014-04-29 21:53:37]

On 2014/04/29 21:44:08, epoger wrote:
> Do you think this CL might be responsible for the following two buildbot
breaks?
>  It's the only CL in both blamelists, aside from Hal's Android-specific CL...
> 
>
http://108.170.220.120:10117/builders/Perf-Win8-ShuttleA-GTX660-x86-Release/b...
> 
>
http://108.170.220.120:10117/builders/Perf-Win7-ShuttleA-HD2000-x86-Release-D...

and maybe this one too???

http://108.170.220.21:10117/builders/Perf-Android-NexusS-SGX540-Arm7-Release/...

[bsalomon, 2014-04-30 13:38:09]

On 2014/04/29 21:53:37, epoger wrote:
> On 2014/04/29 21:44:08, epoger wrote:
> > Do you think this CL might be responsible for the following two buildbot
> breaks?
> >  It's the only CL in both blamelists, aside from Hal's Android-specific
CL...
> > 
> >
>
http://108.170.220.120:10117/builders/Perf-Win8-ShuttleA-GTX660-x86-Release/b...
> > 
> >
>
http://108.170.220.120:10117/builders/Perf-Win7-ShuttleA-HD2000-x86-Release-D...
> 
> and maybe this one too???
> 
>
http://108.170.220.21:10117/builders/Perf-Android-NexusS-SGX540-Arm7-Release/...

These appear to be unrelated flakes.