Changed Order to an enum class and renamed its members

Changed Order to an enum class and renamed its members

Changed Order to an enum class and gave it an unsigned underlying type.
Also renamed it from Order to EOrder to match the other ComputedStyle
enums, and renamed its members to match its keywords from
CSSValueKeywords.in. Also removed the '= 0' value setter for Logical and
the one callsite where this was used (implicit int conversion is not
allowed for enum classes anyway).

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EOrder to be generated in
ComputedStyleBase.

BUG=628043
Committed: https://crrev.com/5fcf8dbc81c32665ab015b7f0cf303f3427a3d93
Cr-Commit-Position: refs/heads/master@{#436233}

[sashab, 2016-12-05 02:00:04]

sashab@chromium.org changed reviewers:
+ napper@chromium.org

[sashab, 2016-12-05 02:00:05]

Note: needed to change CSSProperties.in since this generates StyleBuilder which
relies on the enum name

[napper, 2016-12-05 02:18:22]

lgtm

https://codereview.chromium.org/2546333002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h (right):

https://codereview.chromium.org/2546333002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h:3555: default:
I realize this is not part of your CL but this line is redundant

[sashab, 2016-12-05 02:41:18]

sashab@chromium.org changed reviewers:
+ nainar@chromium.org

[sashab, 2016-12-05 02:41:18]

Ty, nainar@ please review

https://codereview.chromium.org/2546333002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h (right):

https://codereview.chromium.org/2546333002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h:3555: default:
On 2016/12/05 at 02:18:22, napper wrote:
> I realize this is not part of your CL but this line is redundant

The reason it's there I think is otherwise you get a compile error for not
including all the case options in the switch statement :) CSSValueID has like
800 options. These functions are dumb anyway though...

[nainar, 2016-12-05 02:44:55]

lgtm

[sashab, 2016-12-05 02:49:32]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2016-12-05 02:49:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 04:39:43]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480906172131800, "parent_rev":
"86ab2cb0553822427437f8fcd787b8844ead1986", "commit_rev":
"75a545db7eeb949f3a4aada38c6573e1c4435625"}

[commit-bot: I haz the power, 2016-12-05 04:40:10]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-05 04:42:01]

Description was changed from

==========
Changed Order to an enum class and renamed its members

Changed Order to an enum class and gave it an unsigned underlying type.
Also renamed it from Order to EOrder to match the other ComputedStyle
enums, and renamed its members to match its keywords from
CSSValueKeywords.in. Also removed the '= 0' value setter for Logical and
the one callsite where this was used (implicit int conversion is not
allowed for enum classes anyway).

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EOrder to be generated in
ComputedStyleBase.

BUG=628043
==========

to

==========
Changed Order to an enum class and renamed its members

Changed Order to an enum class and gave it an unsigned underlying type.
Also renamed it from Order to EOrder to match the other ComputedStyle
enums, and renamed its members to match its keywords from
CSSValueKeywords.in. Also removed the '= 0' value setter for Logical and
the one callsite where this was used (implicit int conversion is not
allowed for enum classes anyway).

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to move EOrder to be generated in
ComputedStyleBase.

BUG=628043

Committed: https://crrev.com/5fcf8dbc81c32665ab015b7f0cf303f3427a3d93
Cr-Commit-Position: refs/heads/master@{#436233}
==========

[commit-bot: I haz the power, 2016-12-05 04:42:02]

Patchset 1 (id:??) landed as
https://crrev.com/5fcf8dbc81c32665ab015b7f0cf303f3427a3d93
Cr-Commit-Position: refs/heads/master@{#436233}