Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

Issue 2546333002: Changed Order to an enum class and renamed its members (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSProperties.in » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Alexey Proskuryakov <ap@nypop.com>. 2 * Copyright (C) 2007 Alexey Proskuryakov <ap@nypop.com>.
3 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
4 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. 4 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
5 * (http://www.torchmobile.com/) 5 * (http://www.torchmobile.com/)
6 * Copyright (C) 2009 Jeff Schiller <codedread@gmail.com> 6 * Copyright (C) 2009 Jeff Schiller <codedread@gmail.com>
7 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 7 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
8 * 8 *
9 * Redistribution and use in source and binary forms, with or without 9 * Redistribution and use in source and binary forms, with or without
10 * modification, are permitted provided that the following conditions 10 * modification, are permitted provided that the following conditions
(...skipping 3528 matching lines...) Expand 10 before | Expand all | Expand 10 after
3539 case SpeakLiteralPunctuation: 3539 case SpeakLiteralPunctuation:
3540 m_valueID = CSSValueLiteralPunctuation; 3540 m_valueID = CSSValueLiteralPunctuation;
3541 break; 3541 break;
3542 case SpeakNoPunctuation: 3542 case SpeakNoPunctuation:
3543 m_valueID = CSSValueNoPunctuation; 3543 m_valueID = CSSValueNoPunctuation;
3544 break; 3544 break;
3545 } 3545 }
3546 } 3546 }
3547 3547
3548 template <> 3548 template <>
3549 inline Order CSSIdentifierValue::convertTo() const { 3549 inline EOrder CSSIdentifierValue::convertTo() const {
3550 switch (m_valueID) { 3550 switch (m_valueID) {
3551 case CSSValueLogical: 3551 case CSSValueLogical:
3552 return LogicalOrder; 3552 return EOrder::Logical;
3553 case CSSValueVisual: 3553 case CSSValueVisual:
3554 return VisualOrder; 3554 return EOrder::Visual;
3555 default: 3555 default:
napper 2016/12/05 02:18:22 I realize this is not part of your CL but this lin
sashab 2016/12/05 02:41:18 The reason it's there I think is otherwise you get
3556 break; 3556 break;
3557 } 3557 }
3558 3558
3559 ASSERT_NOT_REACHED(); 3559 ASSERT_NOT_REACHED();
3560 return LogicalOrder; 3560 return EOrder::Logical;
3561 } 3561 }
3562 3562
3563 template <> 3563 template <>
3564 inline CSSIdentifierValue::CSSIdentifierValue(Order e) 3564 inline CSSIdentifierValue::CSSIdentifierValue(EOrder e)
3565 : CSSValue(IdentifierClass) { 3565 : CSSValue(IdentifierClass) {
3566 switch (e) { 3566 switch (e) {
3567 case LogicalOrder: 3567 case EOrder::Logical:
3568 m_valueID = CSSValueLogical; 3568 m_valueID = CSSValueLogical;
3569 break; 3569 break;
3570 case VisualOrder: 3570 case EOrder::Visual:
3571 m_valueID = CSSValueVisual; 3571 m_valueID = CSSValueVisual;
3572 break; 3572 break;
3573 } 3573 }
3574 } 3574 }
3575 3575
3576 template <> 3576 template <>
3577 inline ESpeak CSSIdentifierValue::convertTo() const { 3577 inline ESpeak CSSIdentifierValue::convertTo() const {
3578 switch (m_valueID) { 3578 switch (m_valueID) {
3579 case CSSValueNone: 3579 case CSSValueNone:
3580 return SpeakNone; 3580 return SpeakNone;
(...skipping 1163 matching lines...) Expand 10 before | Expand all | Expand 10 after
4744 default: 4744 default:
4745 break; 4745 break;
4746 } 4746 }
4747 ASSERT_NOT_REACHED(); 4747 ASSERT_NOT_REACHED();
4748 return ContainsNone; 4748 return ContainsNone;
4749 } 4749 }
4750 4750
4751 } // namespace blink 4751 } // namespace blink
4752 4752
4753 #endif 4753 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSProperties.in » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698