Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Side by Side Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2546333002: Changed Order to an enum class and renamed its members (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All
7 * rights reserved. 7 * rights reserved.
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
9 * (http://www.torchmobile.com/) 9 * (http://www.torchmobile.com/)
10 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 10 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
(...skipping 4849 matching lines...) Expand 10 before | Expand all | Expand 10 after
4860 4860
4861 DCHECK(newData.encoding().isValid()); 4861 DCHECK(newData.encoding().isValid());
4862 m_encodingData = newData; 4862 m_encodingData = newData;
4863 4863
4864 // FIXME: Should be removed as part of 4864 // FIXME: Should be removed as part of
4865 // https://code.google.com/p/chromium/issues/detail?id=319643 4865 // https://code.google.com/p/chromium/issues/detail?id=319643
4866 bool shouldUseVisualOrdering = m_encodingData.encoding().usesVisualOrdering(); 4866 bool shouldUseVisualOrdering = m_encodingData.encoding().usesVisualOrdering();
4867 if (shouldUseVisualOrdering != m_visuallyOrdered) { 4867 if (shouldUseVisualOrdering != m_visuallyOrdered) {
4868 m_visuallyOrdered = shouldUseVisualOrdering; 4868 m_visuallyOrdered = shouldUseVisualOrdering;
4869 // FIXME: How is possible to not have a layoutObject here? 4869 // FIXME: How is possible to not have a layoutObject here?
4870 if (!layoutViewItem().isNull()) 4870 if (!layoutViewItem().isNull()) {
4871 layoutViewItem().mutableStyleRef().setRTLOrdering( 4871 layoutViewItem().mutableStyleRef().setRTLOrdering(
4872 m_visuallyOrdered ? VisualOrder : LogicalOrder); 4872 m_visuallyOrdered ? EOrder::Visual : EOrder::Logical);
4873 }
4873 setNeedsStyleRecalc(SubtreeStyleChange, 4874 setNeedsStyleRecalc(SubtreeStyleChange,
4874 StyleChangeReasonForTracing::create( 4875 StyleChangeReasonForTracing::create(
4875 StyleChangeReason::VisuallyOrdered)); 4876 StyleChangeReason::VisuallyOrdered));
4876 } 4877 }
4877 } 4878 }
4878 4879
4879 KURL Document::completeURL(const String& url) const { 4880 KURL Document::completeURL(const String& url) const {
4880 return completeURLWithOverride(url, m_baseURL); 4881 return completeURLWithOverride(url, m_baseURL);
4881 } 4882 }
4882 4883
(...skipping 1687 matching lines...) Expand 10 before | Expand all | Expand 10 after
6570 } 6571 }
6571 6572
6572 void showLiveDocumentInstances() { 6573 void showLiveDocumentInstances() {
6573 WeakDocumentSet& set = liveDocumentSet(); 6574 WeakDocumentSet& set = liveDocumentSet();
6574 fprintf(stderr, "There are %u documents currently alive:\n", set.size()); 6575 fprintf(stderr, "There are %u documents currently alive:\n", set.size());
6575 for (Document* document : set) 6576 for (Document* document : set)
6576 fprintf(stderr, "- Document %p URL: %s\n", document, 6577 fprintf(stderr, "- Document %p URL: %s\n", document,
6577 document->url().getString().utf8().data()); 6578 document->url().getString().utf8().data());
6578 } 6579 }
6579 #endif 6580 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698